-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing correct pagination prop names for EuiInMemoryTable #34565
Conversation
Pinging @elastic/stack-monitoring |
I think you meant:
:) |
💔 Build Failed |
💚 Build Succeeded |
@igoristic Is this ready for review yet? I saw me tagged but it's still in draft state |
💔 Build Failed |
It looks like the blocker here has been resolved in eui (elastic/eui#1794). Is this ready for review now? |
@chrisronline Getting pass the first blocker actually unveiled another blocker: elastic/eui#1909 I actually wanted to submit a pull request myself, but wasn't able to set up the EUI repo correctly. I will try to bring up the issue with the EUI team |
💔 Build Failed |
Summary
Resolves #32663
Corrected the pagination naming convention used in
EuiInMemoryTable
.UPDATED:
Initial page index blocker has been implemented: elastic/eui#1794 which unveiled another blocker here: elastic/eui#1909