Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing correct pagination prop names for EuiInMemoryTable #34565

Closed
wants to merge 2 commits into from

Conversation

igoristic
Copy link
Contributor

@igoristic igoristic commented Apr 4, 2019

Summary

Resolves #32663

Corrected the pagination naming convention used in EuiInMemoryTable.

UPDATED:
Initial page index blocker has been implemented: elastic/eui#1794 which unveiled another blocker here: elastic/eui#1909

@igoristic igoristic added blocked WIP Work in progress Team:Monitoring Stack Monitoring team labels Apr 4, 2019
@igoristic igoristic self-assigned this Apr 4, 2019
@igoristic igoristic requested a review from chrisronline April 4, 2019 17:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring

@ycombinator
Copy link
Contributor

Temporary fix until: #1274 improvement is implemented

I think you meant:

Temporary fix until elastic/eui#1274 improvement is implemeted

:)

@igoristic igoristic removed WIP Work in progress blocked labels Apr 4, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@chrisronline
Copy link
Contributor

@igoristic Is this ready for review yet? I saw me tagged but it's still in draft state

@elasticmachine
Copy link
Contributor

💔 Build Failed

@chrisronline
Copy link
Contributor

It looks like the blocker here has been resolved in eui (elastic/eui#1794). Is this ready for review now?

@igoristic
Copy link
Contributor Author

It looks like the blocker here has been resolved in eui (elastic/eui#1794). Is this ready for review now?

@chrisronline Getting pass the first blocker actually unveiled another blocker: elastic/eui#1909

I actually wanted to submit a pull request myself, but wasn't able to set up the EUI repo correctly. I will try to bring up the issue with the EUI team

@elasticmachine
Copy link
Contributor

💔 Build Failed

@igoristic igoristic closed this Dec 21, 2019
@igoristic igoristic deleted the pagination-fix branch December 21, 2019 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Monitoring Stack Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Monitoring] Pagination settings reset after data refresh
4 participants