Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds i18n docs to master #34570

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Conversation

schersh
Copy link
Contributor

@schersh schersh commented Apr 4, 2019

Summary

This PR is a 'forward-port' of #32547 to add the i18n docs to master. Once merged, this will be backported to 7.0 and 7.x.

[skip ci]

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schersh schersh changed the title [DOCS] resolve merge conflict between master and 6.7 [DOCS] Adds i18n docs to master Apr 4, 2019
@schersh schersh merged commit 4bca194 into elastic:master Apr 4, 2019
@schersh schersh deleted the docs/port-i18n-docs branch April 4, 2019 18:15
schersh added a commit that referenced this pull request Apr 4, 2019
schersh added a commit that referenced this pull request Apr 4, 2019
@azasypkin
Copy link
Member

Hi @schersh,

Was this backported to 7.0/7.x? Can't find this neither in master nor 7.0/7.x docs :/

@schersh
Copy link
Contributor Author

schersh commented Apr 22, 2019

Yes, @azasypkin - it's in the same location in master, 7.0, and 7.x:
https://www.elastic.co/guide/en/kibana/7.x/development-plugin-localization.html
These docs also exist in 6.7, which is where Ahmad opened his original PR:
https://www.elastic.co/guide/en/kibana/6.7/development-plugin-localization.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants