Prevent creating a job in the reporting index when the type is immediate #35011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
review
(Deprecated) Feature:Reporting
tsullivan
commented
Apr 12, 2019
x-pack/plugins/reporting/export_types/csv_from_savedobject/server/execute_job.ts
Show resolved
Hide resolved
tsullivan
commented
Apr 12, 2019
| @@ -6,8 +6,6 @@ | |||
|
|
|||
| import { badRequest } from 'boom'; | |||
| import { Request } from 'hapi'; | |||
| // @ts-ignore | |||
| import { createTaggedLogger } from '../../../../server/lib'; | |||
There was a problem hiding this comment.
Cleanup, this was invalid but it had ts-ignore
tsullivan
commented
Apr 12, 2019
| @@ -20,7 +20,7 @@ export interface SavedSearchGeneratorResult { | |||
|
|
|||
| export interface CsvResultFromSearch { | |||
| type: string; | |||
| result: SavedSearchGeneratorResult | null; | |||
| result: SavedSearchGeneratorResult; | |||
There was a problem hiding this comment.
It made things complicated to try to support this being null, since the value gets passed in h.response in the route handler, and h.response does not accept null per TS types.
That is why, further down, the code will check if this is null and convert to undefined
tsullivan
force-pushed
the
feature/reporting/csv-export-panel-action-no-job-create-for-immediate
branch
2 times, most recently
from
f9d25de to
eff1dbb
Compare
tsullivan
force-pushed
the
feature/reporting/csv-export-panel-action-no-job-create-for-immediate
branch
from
eff1dbb to
0bdbf93
Compare
tsullivan
commented
Apr 12, 2019
| @@ -0,0 +1,51 @@ | |||
| /* | |||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | |||
There was a problem hiding this comment.
Added this change for CI to pass. These changes come from #34972
This comment has been minimized.
This comment has been minimized.
…/reporting/csv-export-panel-action-no-job-create-for-immediate
This comment has been minimized.
This comment has been minimized.
…/reporting/csv-export-panel-action-no-job-create-for-immediate
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💚 Build Succeeded |
joelgriffith
force-pushed
the
feature/reporting/csv-export-panel-action
branch
from
3334140 to
4446428
Compare
joelgriffith
merged commit 61c1c1b
into
elastic:feature/reporting/csv-export-panel-action
tsullivan
deleted the
feature/reporting/csv-export-panel-action-no-job-create-for-immediate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the implementation of "immediate" generation of CSV from a saved object, work is done in the "immediate" route handler to craft a job document for the .reporting index, and make sure the generated CSV contents are stored in the index for later re-download.
This has a lot of downsides:
generateCsvwould be called in 2 places: createJob (immediate only) and executeJob (non-immediate only)This PR has the "immediate" route handler calls
createJobandexecuteJobdirectly, not through the helper function that uses ESQueue to create the document in ES. Those functions analyze the request and look up the saved object details for metadata used for generating the content immediately - which now will only happen fromexecuteJob