Gating this feature with a good, old-fashioned config-flag #35029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
requested changes
Apr 12, 2019
x-pack/plugins/reporting/index.js
Outdated
| @@ -125,6 +127,7 @@ export const reporting = (kibana) => { | |||
| }).default() | |||
| }).default(), | |||
| csv: Joi.object({ | |||
| enablePanelActionDownlad: Joi.boolean().default(false), | |||
There was a problem hiding this comment.
enablePanelActionDownload -- missing the o
tsullivan
reviewed
Apr 12, 2019
| @@ -18,6 +18,7 @@ import { registerLegacy } from './legacy'; | |||
| export function registerRoutes(server: KbnServer) { | |||
| const config = server.config(); | |||
| const DOWNLOAD_BASE_URL = config.get('server.basePath') + `${API_BASE_URL}/jobs/download`; | |||
| const hasPanelActionCSVEnabled = config.get('xpack.reporting.csv.enablePanelActionDownlad'); | |||
| const { errors: esErrors } = server.plugins.elasticsearch.getCluster('admin'); | |||
There was a problem hiding this comment.
Lines 20-22 are bothering me because the variables are not defined near the code they are used. Would you mind doing a quick touch-up so they're initialized right above where they're needed?
tsullivan
approved these changes
Apr 12, 2019
💔 Build Failed |
|
retest |
💔 Build Failed |
|
Looks like our integration tests failed, because the new setting must be added to x-pack functional test config. See https://github.com/elastic/kibana/pull/35038/files#diff-6efcd30a7a7fdd7bdab17829239782bcR190 for an example |
added 2 commits
April 15, 2019 13:26
…/reporting/csv-export-panel-action-config-flag
💔 Build Failed |
|
retest |
💔 Build Failed |
…/reporting/csv-export-panel-action-config-flag
💔 Build Failed |
…/reporting/csv-export-panel-action-config-flag
💔 Build Failed |
💚 Build Succeeded |
joelgriffith
merged commit ec6c7e7
into
elastic:feature/reporting/csv-export-panel-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a while to dig all this up, but this seems to be the pattern for exposing config flags to the client.