turning it all into one React app #35185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@bmcconaghy this is awesome!
i didn't test locally yet. it looks like there are a couple files that may have been deleted accidentally.
confirm_watches_modal.tsxform_errors.tsxdelete_watches_modal.tsx
| @@ -0,0 +1,3 @@ | |||
| <kbn-management-app section="elasticsearch/watcher"> | |||
| <div id="watchReactRoot"></div> | |||
| </kbn-management-app> | |||
| @@ -0,0 +1,23 @@ | |||
| /* | |||
There was a problem hiding this comment.
for my own knowledge... do we still need this now that we switched to react router?
There was a problem hiding this comment.
arguably not. probably should be using history for nav.
| {selectedTab === WATCH_EDIT_TAB && ( | ||
| <JsonWatchEditForm urlService={urlService} licenseService={licenseService} /> | ||
| )} | ||
| {selectedTab === WATCH_EDIT_TAB && <JsonWatchEditForm licenseService={licenseService} />} |
There was a problem hiding this comment.
rather than passing this in as a prop, could you just import LicenseServiceContext directly from the JsonWatchEditForm component?
There was a problem hiding this comment.
good point, fixed.
💔 Build Failed |
bmcconaghy
force-pushed
the
watcher-port
branch
from
44f72f1 to
084a8bf
Compare
bmcconaghy
force-pushed
the
watcher-port
branch
from
084a8bf to
048b7e7
Compare
|
@alisonelizabeth thx for the comments, pushed fixes for those things. |
💔 Build Failed |
|
retest |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
retest |
|
retest |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
bmcconaghy
force-pushed
the
watcher-port
branch
from
aeb2fbb to
fc60e58
Compare
💔 Build Failed |
bmcconaghy
force-pushed
the
watcher-port
branch
from
fc60e58 to
5237381
Compare
💔 Build Failed |
bmcconaghy
force-pushed
the
watcher-port
branch
from
5237381 to
97a4a99
Compare
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletes a lot of Angular code and turns it all into one big React app. I still need to address breadcrumbs and reducing the refetching of watches, but those will get addressed in a separate PR.