-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LP plugins can leverage new http server during migration #36120
Closed
mshustov
wants to merge
10
commits into
elastic:master
from
mshustov:expose-http-registerRouter-for-legacy
Closed
LP plugins can leverage new http server during migration #36120
mshustov
wants to merge
10
commits into
elastic:master
from
mshustov:expose-http-registerRouter-for-legacy
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
Feature:New Platform
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
labels
May 6, 2019
Pinging @elastic/kibana-platform |
mshustov
force-pushed
the
expose-http-registerRouter-for-legacy
branch
from
May 7, 2019 16:22
54dbbe1
to
0e6a449
Compare
34 tasks
💚 Build Succeeded |
💚 Build Succeeded |
We shouldn’t move forward with this until we have http route authentication on the new platform, otherwise developers can accidentally bypass security. Unless I’m missing something? |
@epixa this a preparational work to allow Security team to start using NP. actually we can put this PR on block until they are ready to switch |
closed in favour of #39047 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this PR allows legacy plugins to use NP routing during migration.
Parent issue: #33775
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers