Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LP plugins can leverage new http server during migration #36120

Closed

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented May 6, 2019

Summary

this PR allows legacy plugins to use NP routing during migration.
Parent issue: #33775

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@mshustov mshustov added Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels May 6, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@mshustov mshustov marked this pull request as ready for review May 7, 2019 19:00
@mshustov mshustov requested a review from a team as a code owner May 7, 2019 19:00
@elastic elastic deleted a comment from elasticmachine May 7, 2019
@elastic elastic deleted a comment from elasticmachine May 7, 2019
@elastic elastic deleted a comment from elasticmachine May 7, 2019
@elastic elastic deleted a comment from elasticmachine May 7, 2019
@elastic elastic deleted a comment from elasticmachine May 7, 2019
@elastic elastic deleted a comment from elasticmachine May 7, 2019
@mshustov mshustov added the review label May 8, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@epixa
Copy link
Contributor

epixa commented May 8, 2019

We shouldn’t move forward with this until we have http route authentication on the new platform, otherwise developers can accidentally bypass security. Unless I’m missing something?

@mshustov
Copy link
Contributor Author

mshustov commented May 8, 2019

@epixa this a preparational work to allow Security team to start using NP. actually we can put this PR on block until they are ready to switch

@mshustov
Copy link
Contributor Author

closed in favour of #39047

@mshustov mshustov closed this Jun 19, 2019
@mshustov mshustov deleted the expose-http-registerRouter-for-legacy branch June 19, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked chore Feature:New Platform review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants