Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Introducing Timerange Data Mode for Metric Style Visualizations #37185

Merged
merged 55 commits into from
Jul 18, 2019
Merged

[TSVB] Introducing Timerange Data Mode for Metric Style Visualizations #37185

merged 55 commits into from
Jul 18, 2019

Conversation

gospodarsky
Copy link

@gospodarsky gospodarsky commented May 27, 2019 •
edited by timroes
Loading

Fix: #23467

Summary

It has been a long time since the story was created.

This PR attempts to fix a common usability issue with the metric style visualizations by adding a new setting that controls the time range used for matching documents. There are two options:

  • Entire time range will match all the documents selected in the time picker.
  • Last value will match only the documents for the specified interval from the end of the time range.

Before this setting users would often try to use the TSVB metric visualization to display a number for the entire time range not realizing that it was the last bucket. In some instances, users would add an "overall average" then scratch their heads wondering why the average would not match up to the raw values they calculated by hand. This PR is an attempt to try and alleviate that confusion by introducing this new concept up front.

The PR embeds Data timerange mode to the:

  • Metric, Top N, Gauge, Markdown, Table visualizations with Entire time range and Last value options.
  • Rollup Jobs with the Last Value only.

How it looks.

Last value

image

Entire time range

image

Known issues

The value shown if you select an overall timerange of < 30 minutes might be off a bit, due to some Elasticsearch bug (elastic/elasticsearch#43577).

@gospodarsky gospodarsky added the WIP Work in progress label May 27, 2019
@gospodarsky gospodarsky requested a review from a team May 27, 2019 13:38
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@gospodarsky gospodarsky changed the title Add Time Range input to Panel on TSVB Add a Time Range input on TSVB May 28, 2019
@gospodarsky gospodarsky changed the title Add a Time Range input on TSVB [TSVB] Add a Time Range input May 28, 2019
@alexwizp alexwizp changed the title [TSVB] Add a Time Range input [TSVB] Introducing Timerange Data Mode for Metric Style Visualizations May 29, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@gospodarsky gospodarsky requested a review from alexwizp May 31, 2019 14:58
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@spalger spalger added the v7.4.0 label Jul 3, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@gospodarsky gospodarsky merged commit eeb92b4 into elastic:master Jul 18, 2019
@gospodarsky gospodarsky mentioned this pull request Jul 18, 2019
Merged
gospodarsky pushed a commit that referenced this pull request Jul 18, 2019
[TSVB] Introducing Timerange Data Mode for Metric Style Visualizations (
7e740ae 
#37185) (#41440)

* Add Time Range input to Panel on TSVB

* Disable YesNo Component

* Remove redundant translations

* add timerange_data_modes

* Fix reviews

* BE part

* add new ui restriction

* add new ui restriction - ui part

* override index pattern issue

* Take TIME_RANGE_MODE_KEY out

* Make TimeRange more stable

* Small improvements

* Small improvements - BE part

* Small improvements - BE part

* Small improvements - BE part

* Bind uiRestrictions to UI of the Time Range

* Get rid of context consumers

* Remove console.log

* Add translation and refactor a little

* Pretty Panel config
This was referenced Jul 19, 2019
Merged
Closed
@alexwizp alexwizp mentioned this pull request Aug 9, 2019
Closed
@timroes timroes mentioned this pull request Dec 2, 2019
Closed
@alexwizp alexwizp mentioned this pull request Aug 4, 2020
Closed
@alexwizp alexwizp mentioned this pull request Jun 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@timroes timroes timroes approved these changes

@markov00 markov00 Awaiting requested review from markov00

@emmacunningham emmacunningham Awaiting requested review from emmacunningham

Assignees

@timroes timroes

@markov00 markov00

@gospodarsky gospodarsky

@alexwizp alexwizp

@rayafratkina rayafratkina

Labels
Feature:New Feature New feature not correlating to an existing feature label Feature:TSVB TSVB (Time Series Visual Builder) release_note:enhancement v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visual Builder interval auto for Top N, Metric and Gauge
8 participants
@gospodarsky @elasticmachine @rayafratkina @polyfractal @timroes @alexwizp @spalger @markov00