[SIEM] Update Empty Page Messages #37251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngest-dev-457/no-data-messages
…ngest-dev-457/no-data-messages
|
Pinging @elastic/secops |
MichaelMarcialis
added
the
release_note:skip
XavierM
reviewed
May 28, 2019
| title={<h2>{title}</h2>} | ||
| body={<p>{message}</p>} | ||
| body={message && <p>{message}</p>} |
There was a problem hiding this comment.
maybe the function isEmpty from lodash will be a good solution here
There was a problem hiding this comment.
I'm not terribly familiar with lodash. Is there a benefit to using isEmpty versus what I have?
There was a problem hiding this comment.
I think that I will implement it, so like that, it will check for an undefined, null and empty string.
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
FrankHassanabad
approved these changes
May 28, 2019
💔 Build Failed |
…ngest-dev-457/no-data-messages
💔 Build Failed |
|
To fix the localization error, you might have to run: |
…ngest-dev-457/no-data-messages
…ngest-dev-457/no-data-messages # Conflicts: # x-pack/plugins/translations/translations/ja-JP.json
💚 Build Succeeded |
This was referenced May 29, 2019
MichaelMarcialis
added a commit
that referenced
this pull request
May 29, 2019
* [SIEM] Update Empty Page Messages (#37251) * update EmptyPage comp and text on all pages * change proptype from `string` to `IconType` * update tests and snapshots * remove translation imports * restore `align-self` styles for IE11 centering * proper apostrophe and string in single quotes, per frank * update host and ip details * DRYing up host and network empty page message * fix localization * fixing localization again * fix localizations again again
MichaelMarcialis
added a commit
that referenced
this pull request
May 29, 2019
* [SIEM] Update Empty Page Messages (#37251) * update EmptyPage comp and text on all pages * change proptype from `string` to `IconType` * update tests and snapshots * remove translation imports * restore `align-self` styles for IE11 centering * proper apostrophe and string in single quotes, per frank * update host and ip details * DRYing up host and network empty page message * fix localization * fixing localization again * fix localizations again again
dgieselaar
pushed a commit
to dgieselaar/kibana
that referenced
this pull request
May 30, 2019
* [SIEM] Update Empty Page Messages (elastic#37251) * update EmptyPage comp and text on all pages * change proptype from `string` to `IconType` * update tests and snapshots * remove translation imports * restore `align-self` styles for IE11 centering * proper apostrophe and string in single quotes, per frank * update host and ip details * DRYing up host and network empty page message * fix localization * fixing localization again * fix localizations again again
jkakavas
pushed a commit
to jkakavas/kibana
that referenced
this pull request
May 30, 2019
* update EmptyPage comp and text on all pages * change proptype from `string` to `IconType` * update tests and snapshots * remove translation imports * restore `align-self` styles for IE11 centering * proper apostrophe and string in single quotes, per frank * update host and ip details * DRYing up host and network empty page message * fix localization * fixing localization again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the empty page messages across the SIEM application. Changes include basic text edits and updates to the
EmptyPagecomponent (to support a secondary action button, button icons, and button targets).Issue Ticket: https://github.com/elastic/ingest-dev/issues/457
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Documentation was added for features that require explanation or tutorialsFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately