Embeddable API V2 #37510
Merged
Embeddable API V2 #37510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-app-arch |
stacey-gammon
force-pushed
the
2019-05-30-embeddable-api-plugin
branch
3 times, most recently
from
cc8eb7c to
13fe695
Compare
10 tasks
stacey-gammon
force-pushed
the
2019-05-30-embeddable-api-plugin
branch
from
13fe695 to
3ab2f83
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
stacey-gammon
force-pushed
the
2019-05-30-embeddable-api-plugin
branch
from
92ae180 to
8471233
Compare
💚 Build Succeeded |
💔 Build Failed |
|
The mere existence of my sample plugin somehow causes other functional plugin tests to fail, but only on jenkins, it works fine locally. I will have to dig deeper to see what exactly is causing the issue. |
stacey-gammon
force-pushed
the
2019-05-30-embeddable-api-plugin
branch
from
84fac68 to
e2d0859
Compare
💔 Build Failed |
stacey-gammon
force-pushed
the
2019-05-30-embeddable-api-plugin
branch
from
e2d0859 to
64e2c03
Compare
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
stacey-gammon
force-pushed
the
2019-05-30-embeddable-api-plugin
branch
from
b0446bf to
df48ee9
Compare
|
can someone from @elastic/kibana-operations look at the changes I did to get rxjs working with multiple bundles. @spalger maybe? |
streamich
approved these changes
Jun 6, 2019
💔 Build Failed |
💔 Build Failed |
|
Retest |
💚 Build Succeeded |
|
retest |
…beddable-api-plugin
💔 Build Failed |
💔 Build Failed |
|
maps sample data test has failed a couple times in this PR and in a typescript one. jenkins, test this |
💚 Build Succeeded |
spalger
suggested changes
Jun 7, 2019
💚 Build Succeeded |
stacey-gammon
added
v8.0.0
release_note:skip
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Jun 10, 2019
* Embeddable API plugin * Expose new embeddableActions uiExport endpoint * Add missing getInjectedUIAppVars to Server type * Add jest tests * Most basic skeleton of the sample plugin to see if it still kills ci * strip even more out to see if it passes ci * It passed, put back init fn * add back in a uiExport to see if that is what is killing ci * Passed again, add back embeddableActions uiExports and require kibana line * Add everything back but the sass import * Found two bugs with customize panel title action, added jest test coverage and fixes * Functionally test embeddable explorer plugin * Addressing review feedback part 1 * Simplify action context menu - remove support for nested actions/child panels, which was never exposed anyway. * More review feedback * Spread out orders to let developers inject their own actions in the middle. * Remove check for overwriting ApplyFilterAction * use createRegistry for EmbeddableFactoryRegistry * Add comment for getInheritedInput * Use kbn-es-query Filter types * Fix missed file after createRegistry switch over for EmbeddableFactoryRegistry * Use delete instead of setting to undefined * upgrade EUI to match kibana version * Add getIsContainer on base embeddable class * Run functional tests of sample plugin * move all tests classes outside __test__ and inside test_samples folder so not to potentially create issues with mocha * fix: 🐛 remove unused imports * fix: 🐛 set to undefined explicitly * chore: refactored getRoot functionality * fix: refactor miss from folder rename __test__ -> test_samples * fix: add eui switch to let the user indicate “hide this title” to improve ux. * fix: customize panel flout test * Try to fix issue with multiple rxjs bundles I hit before. See ReactiveX/rxjs#3828 * Use an rxjs polyfill to work around the issue of multiple rxjs bundles * chore: change customize panel flyout to modal post design feedback * capitalize Reset * fix: type errors in customize panel modal * fix: remove extra line added to prevent EUICallout overflow from spilling over panel edges The bug this was intended to fix doesn’t appear yet because dashboard isn’t using this, and it causes other issues, so for now, just remove. * Clean up some classes and SASS * Inline styles needed to get the containers to take up the full height of the app. * Use the same old style of error messaging in panels * chore: add untilEmbeddableLoaded tests, expose on interface, and use in embeddable_child_panel * Remove unused styles, add padding * Verify trigger Context containers an array of Filters for apply filter action * Remove panel.embeddableId param, use panel.explicitInput.id instead * Check `isCompatible` as well as the type guard needed for typescript. * executeTriggerActions should account for getHref * Remove unnecessary check for context being defined * use npStart instead of getNewPlatform * Conform to latest NP changes * Use new np_mocks in all the tests * Address review feedback on rxjs polyfill
stacey-gammon
added a commit
that referenced
this pull request
Jun 10, 2019
* Embeddable API plugin * Expose new embeddableActions uiExport endpoint * Add missing getInjectedUIAppVars to Server type * Add jest tests * Most basic skeleton of the sample plugin to see if it still kills ci * strip even more out to see if it passes ci * It passed, put back init fn * add back in a uiExport to see if that is what is killing ci * Passed again, add back embeddableActions uiExports and require kibana line * Add everything back but the sass import * Found two bugs with customize panel title action, added jest test coverage and fixes * Functionally test embeddable explorer plugin * Addressing review feedback part 1 * Simplify action context menu - remove support for nested actions/child panels, which was never exposed anyway. * More review feedback * Spread out orders to let developers inject their own actions in the middle. * Remove check for overwriting ApplyFilterAction * use createRegistry for EmbeddableFactoryRegistry * Add comment for getInheritedInput * Use kbn-es-query Filter types * Fix missed file after createRegistry switch over for EmbeddableFactoryRegistry * Use delete instead of setting to undefined * upgrade EUI to match kibana version * Add getIsContainer on base embeddable class * Run functional tests of sample plugin * move all tests classes outside __test__ and inside test_samples folder so not to potentially create issues with mocha * fix: 🐛 remove unused imports * fix: 🐛 set to undefined explicitly * chore: refactored getRoot functionality * fix: refactor miss from folder rename __test__ -> test_samples * fix: add eui switch to let the user indicate “hide this title” to improve ux. * fix: customize panel flout test * Try to fix issue with multiple rxjs bundles I hit before. See ReactiveX/rxjs#3828 * Use an rxjs polyfill to work around the issue of multiple rxjs bundles * chore: change customize panel flyout to modal post design feedback * capitalize Reset * fix: type errors in customize panel modal * fix: remove extra line added to prevent EUICallout overflow from spilling over panel edges The bug this was intended to fix doesn’t appear yet because dashboard isn’t using this, and it causes other issues, so for now, just remove. * Clean up some classes and SASS * Inline styles needed to get the containers to take up the full height of the app. * Use the same old style of error messaging in panels * chore: add untilEmbeddableLoaded tests, expose on interface, and use in embeddable_child_panel * Remove unused styles, add padding * Verify trigger Context containers an array of Filters for apply filter action * Remove panel.embeddableId param, use panel.explicitInput.id instead * Check `isCompatible` as well as the type guard needed for typescript. * executeTriggerActions should account for getHref * Remove unnecessary check for context being defined * use npStart instead of getNewPlatform * Conform to latest NP changes * Use new np_mocks in all the tests * Address review feedback on rxjs polyfill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is all the new code for the new Actionable Embeddable API. It does not switch any code over to actually using it. It is possible, see #35622 for proof, but putting it all together creates a giant PR, so stage 1 will be checking this new code in, currently unused except for the sample plugin that is functionally tested. Jest tests are included as well.
To run the sample plugin, start via:
Then navigate to the Embeddable Explorer app.
Jest test coverage numbers: