Per panel time range #39937
Per panel time range #39937
Conversation
💔 Build Failed |
stacey-gammon
force-pushed
the
2019-06-28-time-range-per-panel
branch
from
3497eed
to
68c3519
Compare
💔 Build Failed |
|
retest |
💔 Build Failed |
stacey-gammon
force-pushed
the
2019-06-28-time-range-per-panel
branch
4 times, most recently
from
be93ca1
to
264c904
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
stacey-gammon
force-pushed
the
2019-06-28-time-range-per-panel
branch
from
264c904
to
615669e
Compare
💔 Build Failed |
stacey-gammon
force-pushed
the
2019-06-28-time-range-per-panel
branch
from
615669e
to
09ee01f
Compare
💔 Build Failed |
stacey-gammon
force-pushed
the
2019-06-28-time-range-per-panel
branch
from
09ee01f
to
1460884
Compare
💔 Build Failed |
stacey-gammon
force-pushed
the
2019-06-28-time-range-per-panel
branch
from
1460884
to
1a7f7f0
Compare
💚 Build Succeeded |
|
Just need the pretty print functionality from EUI and this is ready to GO! woot! |
stacey-gammon
force-pushed
the
2019-06-28-time-range-per-panel
branch
from
1a7f7f0
to
14ed5b5
Compare
💔 Build Failed |
|
failed on going to pull in master and retry. |
…me-range-per-panel
💚 Build Succeeded |
| </EuiModalHeader> | ||
|
|
||
| <EuiModalBody> | ||
| {' '} |
There was a problem hiding this comment.
Why is there an empty space here?
There was a problem hiding this comment.
I do not know, I remove all the weird spaces in this file.
| )} | ||
| </EuiButtonEmpty> | ||
|
|
||
| <EuiButton |
There was a problem hiding this comment.
This flex group stuff still needs to be cleaned up. There's too many nested FlexGroups. You can use the code above for the layout.
|
@AlonaNadler - good call, I missed that the recent time ranges were different. It's now pulling from advanced settings so they should match.
|
💚 Build Succeeded |
|
I'm noticing that if the panels get really skinny, the time range badge can become completely invisible.
I'll have to give you a PR that will allow the panel title to wrap its contents. Another quick question, should user's be able to customize time ranges when not in edit mode? |
|
Ah, awesome, good catch re: the wrapping.
Yep, that is intentional, so a user who doesn't have edit rights can still temporarily see the different time range, it just won't be saved with the panel like it would in edit mode. If that seems too confusing we can talk about removing it, but I'm pretty sure @AlonaNadler thinks users will find that functionality useful. |
…me-range-per-panel
|
PR4U: stacey-gammon#10
I think it's fine to allow this in non-edit mode, I just think it's currently unclear that this won't be saved with the dashboard. But I'm not really sure how to mitigate that. |
💚 Build Succeeded |
…me-range-per-panel
|
Ping @ppisljar or @streamich for review. :) (I promise @streamich I'm going to review your inspector -> NP today!) |
💚 Build Succeeded |
x-pack/legacy/plugins/advanced_ui_actions/public/custom_time_range_action.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/advanced_ui_actions/public/custom_time_range_badge.tsx
Outdated
Show resolved
Hide resolved
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| import { PluginInitializerContext, CoreStart } from 'src/core/public'; |
There was a problem hiding this comment.
this is not shim and should be moved one level up i think @streamich ?
|
Hey @stacey-gammon Did you see my PR I made for you that will fix the wrapping header? stacey-gammon#10 |
💔 Build Failed |
Summary
Each panel on a dashboard can now be configured to show a custom time range, independent from the global one. Just go to the menu options and select
Customize time range. If the panel's time range is different than what is showing in the global time picker, it will contain a visible badge showing the date.fixes #17776 and #3578