Role Management - use ES Builtin Privilege API to drive list of privileges #40270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legrego
changed the title
This comment has been minimized.
This comment has been minimized.
legrego
commented
Jul 8, 2019
| * you may not use this file except in compliance with the Elastic License. | ||
| */ | ||
|
|
||
| export interface BuiltinESPrivileges { |
Member
Author
There was a problem hiding this comment.
I'm not married to the name, but I thought I'd keep it consistent with what ES chose to call this.
Contributor
💚 Build Succeeded |
legrego
commented
Jul 8, 2019
| kibanaPrivileges() { | ||
| return kfetch({ method: 'get', pathname: '/api/security/privileges', query: { includeActions: true } }); | ||
| }, | ||
| builtinESPrivileges() { |
Member
Author
There was a problem hiding this comment.
Once we de-angularize, I think it'd make sense to make the ElasticsearchPrivileges component (or similar) responsible for this, rather than passing it down from the EditRolesPage component. I opted for this approach to stay consistent with the rest of the page, and we can come up with a holistic data-access approach for the entire screen once we remove angular.
legrego
added
Feature:Security/Authorization
Contributor
|
Pinging @elastic/kibana-security |
legrego
added
the
release_note:skip
Contributor
💚 Build Succeeded |
kobelb
approved these changes
Jul 10, 2019
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Jul 10, 2019
…tic#40270) * use ES builtin privileges API for role management * Exclude 'none' from privilege lists * additional cleanup
55 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces hard-coded cluster and index privileges with a list generated from the ES builtin privileges endpoint (
/_security/privilege/_builtin).Closes #40247
Note: CI will fail until the ES snapshot is updated with the new endpoint.