chore: 🤖 forbid import from ui/**

.eslintrc.js

@@ -156,6 +156,19 @@ module.exports = {
                 ],
                 allowSameFolder: true,
               },
+              {
+                from: ['src/legacy/ui/**/*', 'ui/**/*'],
+                target: [
+                  'src/legacy/core_plugins/**/public/shim/**/*',
+                  'src/legacy/core_plugins/**/server/shim/**/*',
+                ],
+                allowSameFolder: true,
+                errorMessage:
+                  'Shim should not import from /src/legacy/ui/** folder. ' +
+                  'Instead of importing from /src/legacy/ui/** deeply withing a shim, ' +
+                  'import those things once at the top level of your shim and pass those down, just ' +
+                  'like you pass down `core` and `plugins` objects.',
+              },
             ],
           },
         ],

packages/kbn-eslint-plugin-eslint/rules/no_restricted_paths.js

@@ -97,11 +97,16 @@ module.exports = {
     }
 
     function checkForRestrictedImportPath(importPath, node) {
-      const absoluteImportPath = resolve(importPath, context);
-      if (!absoluteImportPath) return;
+      let absoluteImportPath;
+      if (importPath.indexOf('ui/') === 0) {
+        absoluteImportPath = importPath;
+      } else {
+        absoluteImportPath = resolve(importPath, context);
+        if (!absoluteImportPath) return;
+      }
 
       const currentFilename = context.getFilename();
-      for (const { target, from, allowSameFolder } of zones) {
+      for (const { target, from, allowSameFolder, errorMessage = '' } of zones) {
         const srcFilePath = resolve(currentFilename, context);
 
         const relativeSrcFile = path.relative(basePath, srcFilePath);
@@ -116,7 +121,9 @@ module.exports = {
 
         context.report({
           node,
-          message: `Unexpected path "${importPath}" imported in restricted zone.`,
+          message: `Unexpected path "${importPath}" imported in restricted zone.${
+            errorMessage ? ' ' + errorMessage : ''
+          }`,
         });
       }
     }

src/legacy/core_plugins/dashboard_embeddable_container/public/shim/index.ts

@@ -18,6 +18,7 @@
  */
 
 import { PluginInitializerContext } from 'kibana/public';
+// eslint-disable-next-line @kbn/eslint/no-restricted-paths
 import { npSetup, npStart } from 'ui/new_platform';
 import { embeddablePlugin } from '../../../embeddable_api/public';
 import { Plugin } from './plugin';