Updated the ZeroFilled class to only fill when necessary #406
Conversation
updated the getFlotPairs() function to only check before and after a value, adding only enough zeros to maintain line graphs.
… introduced the fill_style option ("minimal" and
"all" are possible values). Also allowed a set of required times to be specified when asking the times series for it's
data. This way, we can ensure in the stacked bar chart that each data point in use has a value preventing the bars
from stacking incorrectly.
|
@olej-a mind giving this a shot and seeing how it works? |
|
It is bettter. I don't understand why zero values starts or ends on different positions. There are missing zero values on the end. I don't check source code. There may be problem with interval_to_seconds. But it is only visual detail. Line graph looks ok. Bar graph is OK too. See screenshots.
There is one error in bar graph - width of bars and overlapped bars. Problem is visible if resolution interval is less than second. See my commit olej-a@e89f9b7 How bar graph looks now : I would be happy if you could check my commits to histogram panel - moving in time left and right, move to now and display timeframe information. Moving in time and timeframe info is real bonus to histogram usability. See my pull request #299 |
|
Yep, this is a bug in interval_to_seconds, working on this now |
update protofiles to add tags
The new ZeroFill time series class created a lot of data points, which caused flot to perform poorly and wasn't really necessary. This modification will only place zero's before/after a measurements when there isn't an existing measurement there. This ensures that the lines drawn by flot are accurate.
This also sets the line width on the bars to 0, so that 0 measurements won't show up on bar charts.