Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting/FN Test] use a smaller archive for scripted field testing #40815

Merged
merged 4 commits into from
Jul 12, 2019
Merged

[Reporting/FN Test] use a smaller archive for scripted field testing #40815

merged 4 commits into from
Jul 12, 2019

Conversation

tsullivan
Copy link
Member

Summary

Resolves #37471

This seems like a true timeout due to overhead of scripted fields over a large data set. This creates a smaller copy of the reporting/scripted esArchive to use a lot of documents from the es archive used for this functional test:

Index name: babynames
Previous doc count: 1552
Current doc count: 200

Previously, I would see the test take around 30 seconds to run. The test now seems to run a lot faster!

@tsullivan tsullivan added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes skipped-test v7.3.0 v7.4.0 v8.0.0 and removed v7.3.0 labels Jul 10, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@tsullivan tsullivan requested review from joelgriffith and LeeDr July 11, 2019 16:19
@joelgriffith
Copy link
Contributor

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@tsullivan tsullivan merged commit a51d1bd into elastic:master Jul 12, 2019
@tsullivan tsullivan deleted the reporting/test-re-enable-scripted branch July 12, 2019 21:23
@tsullivan tsullivan mentioned this pull request Jul 12, 2019
Closed
@spalger spalger mentioned this pull request Jul 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelgriffith joelgriffith joelgriffith approved these changes

@LeeDr LeeDr Awaiting requested review from LeeDr

Assignees
No one assigned
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes skipped-test v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
3 participants
@tsullivan @elasticmachine @joelgriffith