Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoodBye Notifier #41663

Merged
merged 6 commits into from
Jul 23, 2019
Merged

GoodBye Notifier #41663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a05d684
Begin notifier removal
timroes Jul 11, 2019
a0ffbb1
Merge branch 'master' into remove-notifier
Jul 22, 2019
b0fc98b
Remove remaining notifier traces
Jul 22, 2019
c226951
Remove dead translations
Jul 22, 2019
34243dc
Remove Angular from config listener
Jul 22, 2019
131d553
Import angular-sanitize explicitly in map
Jul 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/plugins/known-plugins.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ This list of plugins is not guaranteed to work on your version of Kibana. Instea
[float]
=== Other
* https://github.com/nreese/kibana-time-plugin[Time picker as a dashboard panel] Widget to view and edit the time range from within dashboards.
* https://github.com/sw-jung/kibana_notification_center[Notification Center] (sw-jung) - for better experience of notifier toasts.
Copy link
Contributor Author

@timroes timroes Jul 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ I removed the notification center plugin, since it only worked for Notifier notifications.


* https://github.com/Webiks/kibana-API.git[Kibana-API] (webiks) Exposes an API with Kibana functionality.
Use it to create, edit and embed visualizations, and also to search inside an embedded dashboard.
Expand Down
1 change: 0 additions & 1 deletion src/legacy/core_plugins/kibana/public/context/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ const module = uiModules.get('apps/context', [
'elasticsearch',
'kibana',
'kibana/config',
'kibana/notify',
'ngRoute',
]);

Expand Down
1 change: 0 additions & 1 deletion src/legacy/core_plugins/kibana/public/discover/controllers/discover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ const fetchStatuses = {
};

const app = uiModules.get('apps/discover', [
'kibana/notify',
'kibana/courier',
'kibana/url',
'kibana/index_patterns'
Expand Down
1 change: 0 additions & 1 deletion src/legacy/core_plugins/kibana/public/discover/saved_searches/_saved_search.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import { createLegacyClass } from 'ui/utils/legacy_class';
import { SavedObjectProvider } from 'ui/saved_objects/saved_object';

const module = uiModules.get('discover/saved_searches', [
'kibana/notify',
'kibana/courier'
]);

Expand Down
4 changes: 1 addition & 3 deletions src/legacy/core_plugins/kibana/public/discover/saved_searches/saved_searches.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@ import 'ui/notify';
import { uiModules } from 'ui/modules';
import { SavedObjectLoader, SavedObjectsClientProvider } from 'ui/saved_objects';
import { savedObjectManagementRegistry } from '../../management/saved_object_registry';
const module = uiModules.get('discover/saved_searches', [
'kibana/notify'
]);
const module = uiModules.get('discover/saved_searches');

// Register this service with the saved object registry so it can be
// edited by the object editor.
Expand Down
1 change: 0 additions & 1 deletion src/legacy/core_plugins/kibana/public/doc/controllers/doc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import 'plugins/kibana/doc_viewer';
import { getRootBreadcrumbs } from 'plugins/kibana/discover/breadcrumbs';

const app = uiModules.get('apps/doc', [
'kibana/notify',
'kibana/courier',
'kibana/index_patterns'
]);
Expand Down
1 change: 0 additions & 1 deletion src/legacy/core_plugins/kibana/public/visualize/editor/editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ uiRoutes

uiModules
.get('app/visualize', [
'kibana/notify',
'kibana/url'
])
.directive('visualizeApp', function () {
Expand Down
4 changes: 0 additions & 4 deletions src/legacy/ui/public/chrome/directives/kbn_chrome.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
<div class="app-wrapper-panel">
<kbn-notifications
list="notifList"
></kbn-notifications>

<div id="globalBannerList"></div>

<div
Expand Down
4 changes: 0 additions & 4 deletions src/legacy/ui/public/chrome/directives/kbn_chrome.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import { uiModules } from '../../modules';
import template from './kbn_chrome.html';

import {
notify,
GlobalBannerList,
banners,
} from '../../notify';
Expand Down Expand Up @@ -58,9 +57,6 @@ export function kbnChromeProvider(chrome, internals) {

controllerAs: 'chrome',
controller($scope, $location, Private) {
// Notifications
$scope.notifList = notify._notifs;

$scope.getFirstPathSegment = () => {
return $location.path().split('/')[1];
};
Expand Down
114 changes: 0 additions & 114 deletions src/legacy/ui/public/directives/__tests__/truncate.js
View file
Open in desktop

This file was deleted.

165 changes: 0 additions & 165 deletions src/legacy/ui/public/notify/__tests__/notifier.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/legacy/ui/public/notify/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
@import './banners/index';
@import './partials/index';
Loading