Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EUI 13.0.0 #41723

Merged
merged 4 commits into from
Jul 23, 2019
Merged

EUI 13.0.0 #41723

merged 4 commits into from
Jul 23, 2019

Conversation

snide
Copy link
Contributor

@snide snide commented Jul 22, 2019

Summary

Updates to the latest EUI, which required changes to Kibana mostly around removal of the K6 themes.

13.0.0

  • Added EuiSuggestItem component (#2090)
  • Added support for negated or clauses to EuiSearchBar (#2140)
  • Added transition utility services to help create timeouts that account for CSS transition durations and delays (#2136)
  • Removed EuiFlexGroup dependency from EuiAccordion (#2143)
  • Exported prettyDuration and commonDurationRanges for pretty printing date ranges outside EuiSuperDatePicker (#2132)

Bug fixes

  • Fixed EuiComboBox's padding on the right (#2135)
  • Fixed EuiAccordion to correctly account for changing computed height of child elements (#2136)
  • Fixed some EuiFlyout sizing (#2125)

Breaking changes

  • Removed EuiSeriesChart and related components. Please look to Elastic Charts for a replacement. (#2135)
  • Removed eui_k6_theme related Sass and JSON files (#2135)
  • Removed no longer used Sass mixins and variables in EuiForm, EuiCallOut, and EuiRange components (#2135)

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@snide snide added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 labels Jul 22, 2019
@snide
Copy link
Contributor Author

snide commented Jul 22, 2019

@thompsongl @chandlerprall Set this up so that I could fix the K6 theming issues I knew we'd need to fix. Looks like some changes will need to be done to the Jest tests due to the accordion changes. Left this in draft mode for now.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@thompsongl
Copy link
Contributor

Looks like this needs to be rebased. EUI is at 12.4.0 in master. At least a couple of the test failures will be fixed by rebase

@snide
Copy link
Contributor Author

snide commented Jul 23, 2019

@thompsongl merged back up. Still a bunch in jest.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@thompsongl
Copy link
Contributor

@snide This is good to come out of Draft, I think

@snide snide marked this pull request as ready for review July 23, 2019 19:18
@snide snide requested review from a team as code owners July 23, 2019 19:18
@snide
Copy link
Contributor Author

snide commented Jul 23, 2019

For outside review pings. This is an EUI upgrade and comes with the usual snapshot updates. This is a major version change for EUI, but the only change was the removal of the EuiSeriesCharts components which are no longer in use in Kibana so there's nothing to review there. I made some small changes to some of the consuming apps that were still calling the k6 theme json, which we also removed. We also updated the tests where appropriate.

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM2!

@snide snide merged commit c2b926e into elastic:master Jul 23, 2019
@snide snide deleted the eui/13.0.0 branch July 23, 2019 22:09
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes look good!

@snide snide mentioned this pull request Aug 2, 2019
snide added a commit to snide/kibana that referenced this pull request Aug 2, 2019
snide added a commit that referenced this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants