-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EUI 13.0.0 #41723
EUI 13.0.0 #41723
Conversation
@thompsongl @chandlerprall Set this up so that I could fix the K6 theming issues I knew we'd need to fix. Looks like some changes will need to be done to the Jest tests due to the accordion changes. Left this in draft mode for now. |
💔 Build Failed |
Looks like this needs to be rebased. EUI is at 12.4.0 in master. At least a couple of the test failures will be fixed by rebase |
@thompsongl merged back up. Still a bunch in jest. |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
@snide This is good to come out of Draft, I think |
For outside review pings. This is an EUI upgrade and comes with the usual snapshot updates. This is a major version change for EUI, but the only change was the removal of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM2!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APM changes look good!
Summary
Updates to the latest EUI, which required changes to Kibana mostly around removal of the K6 themes.
13.0.0
EuiSuggestItem
component (#2090)EuiSearchBar
(#2140)transition
utility services to help create timeouts that account for CSS transition durations and delays (#2136)EuiFlexGroup
dependency fromEuiAccordion
(#2143)prettyDuration
andcommonDurationRanges
for pretty printing date ranges outsideEuiSuperDatePicker
(#2132)Bug fixes
EuiComboBox
's padding on the right (#2135)EuiAccordion
to correctly account for changing computed height of child elements (#2136)EuiFlyout
sizing (#2125)Breaking changes
EuiSeriesChart
and related components. Please look to Elastic Charts for a replacement. (#2135)eui_k6_theme
related Sass and JSON files (#2135)EuiForm
,EuiCallOut
, andEuiRange
components (#2135)Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This includes a feature addition or change that requires a release note and was labeled appropriately