Do not check built-in plugin manifests for version #41905
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version and kibanaVersion properties in the new platform plugin manifest files are needed to ensure external plugins are built for the current Kibana version, but this isn't necessary for built-in plugins because they are always built with Kibana itself.
epixa
added
Feature:Plugins
Team:Core
|
Pinging @elastic/kibana-platform |
💔 Build Failed |
|
I'm not going to have time to pull this over the line, so I'm closing. If anyone wants to pick up where I left off, go for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version and kibanaVersion properties in the new platform plugin
manifest files are needed to ensure external plugins are built for the
current Kibana version, but this isn't necessary for built-in plugins
because they are always built with Kibana itself.
Closes #34660