Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] expose EMSClient after platform shim #42073

Merged
merged 1 commit into from
Jul 26, 2019
Merged

[Maps] expose EMSClient after platform shim #42073

merged 1 commit into from
Jul 26, 2019

Conversation

thomasneirynck
Copy link
Contributor

Closes #42028

Was introduced after this refactor #41265

@thomasneirynck thomasneirynck added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 labels Jul 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

alexwizp
alexwizp approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tile Map plugin tested locally, works fine.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

kindsun
kindsun approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

  • code review

nickpeihl
nickpeihl approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! code review

@thomasneirynck thomasneirynck merged commit d12da37 into elastic:master Jul 26, 2019
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Jul 26, 2019
@thomasneirynck
[Maps] fix EMSClient import (elastic#42073)
2f9e5f1
@thomasneirynck thomasneirynck mentioned this pull request Jul 26, 2019
Merged
thomasneirynck added a commit that referenced this pull request Jul 26, 2019
@thomasneirynck
[Maps] fix EMSClient import (#42073) (#42083)
5c2aadc
@thomasneirynck thomasneirynck mentioned this pull request Jul 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

@kindsun kindsun kindsun approved these changes

@Bamieh Bamieh Bamieh approved these changes

@alexwizp alexwizp alexwizp approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maps plugin not loading EMSClient of undefined
6 participants
@thomasneirynck @elasticmachine @nickpeihl @kindsun @Bamieh @alexwizp