[Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern #42287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Closes elastic#42275 - Removes derivedIndexPattern - Adds createDerivedIndexPattern(type: 'logs' | 'metrics' | 'both') - Replaces all instances of derivedIndexPattern from WithSource with results of createDerivedIndexPattern()
simianhacker
added
release_note:fix
Feature:Metrics UI
|
Pinging @elastic/infra-logs-ui |
💔 Build Failed |
💚 Build Succeeded |
skh
reviewed
Jul 31, 2019
x-pack/legacy/plugins/infra/public/containers/source/source.tsx
Outdated
Show resolved
Hide resolved
skh
approved these changes
Jul 31, 2019
💚 Build Succeeded |
💚 Build Succeeded |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Aug 2, 2019
…ern (elastic#42287) * [Infra UI] Fix autocompete on inventry page to use proper indexPattern - Closes elastic#42275 - Removes derivedIndexPattern - Adds createDerivedIndexPattern(type: 'logs' | 'metrics' | 'both') - Replaces all instances of derivedIndexPattern from WithSource with results of createDerivedIndexPattern() * Fixing a missed conversion * Removing useCallback
simianhacker
added a commit
that referenced
this pull request
Aug 2, 2019
…ern (#42287) (#42543) * [Infra UI] Fix autocompete on inventry page to use proper indexPattern - Closes #42275 - Removes derivedIndexPattern - Adds createDerivedIndexPattern(type: 'logs' | 'metrics' | 'both') - Replaces all instances of derivedIndexPattern from WithSource with results of createDerivedIndexPattern() * Fixing a missed conversion * Removing useCallback
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 5, 2019
…-or-edit-existing-rollup-job * 'master' of github.com:elastic/kibana: (67 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 5, 2019
…s_autocomplete * 'master' of github.com:elastic/kibana: (189 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR closed #42275 by removing the
derivedIndexPatternfrom theSource.Contextand replacing it with a method to create thederivedIndexPatternbased on the type you need (logs|metrics|both). This way when looking at Metrics Explorer or Inventory the fields (and values) are using the same index as the content on the page. The changes to the Logs UI only affect how thederivedIndexPatternis accessed, the functionality should remain the same.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibility