[code] Enable go langserver under non-detach mode. #42352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/code |
movie-travel-code
changed the title
movie-travel-code
changed the title
💚 Build Succeeded |
💚 Build Succeeded |
movie-travel-code
force-pushed
the
GoNonDetachMode
branch
from
abe1fd6 to
def257c
Compare
💚 Build Succeeded |
movie-travel-code
force-pushed
the
GoNonDetachMode
branch
from
def257c to
f259165
Compare
💚 Build Succeeded |
💔 Build Failed |
added 4 commits
August 6, 2019 14:57
We should keep the kibana code data inside the 'kibana/data' . That means go-langserver has nothing to do with dev machine except '$PATH'.
Since we use socket as the process communication media, remove the unused parameter.
movie-travel-code
force-pushed
the
GoNonDetachMode
branch
from
74e3c4b to
5af590f
Compare
💚 Build Succeeded |
movie-travel-code
pushed a commit
to movie-travel-code/kibana
that referenced
this pull request
Aug 6, 2019
* [code] Enable go langserver under non-detach mode. * [code] Enable go langserver under non-detach mode #part 2. * [code] Enable go langserver under non-detach mode #part 3 We should keep the kibana code data inside the 'kibana/data' . That means go-langserver has nothing to do with dev machine except '$PATH'. * [code] Enable go langserver under non-detach mode #part 4 Since we use socket as the process communication media, remove the unused parameter.
movie-travel-code
pushed a commit
that referenced
this pull request
Aug 6, 2019
* [code] Enable go langserver under non-detach mode. * [code] Enable go langserver under non-detach mode #part 2. * [code] Enable go langserver under non-detach mode #part 3 We should keep the kibana code data inside the 'kibana/data' . That means go-langserver has nothing to do with dev machine except '$PATH'. * [code] Enable go langserver under non-detach mode #part 4 Since we use socket as the process communication media, remove the unused parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For a little bit of context,
If there is nogoinstalled locally, use the bundled go toolchainkibana/data/code/gopath/pkg/mod.Checklist
[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers