Make task manager index configurable again #42394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-stack-services |
This comment has been minimized.
This comment has been minimized.
mikecote
force-pushed
the
task-manager/custom-index
branch
from
1869b3d to
a2b4fe5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
joshdover
reviewed
Aug 1, 2019
| convertToAliasScript: `ctx._id = ctx._source.type + ':' + ctx._id`, | ||
| indexPattern(config) { | ||
| return config.get('xpack.task_manager.index'); | ||
| }, |
There was a problem hiding this comment.
Ah I was expecting the entire savedObjectSchema to be a function to be more similar to other uiExports. If you're confident there's no use case for that, then this is fine.
There was a problem hiding this comment.
Yeah I can't think of any yet. I believe if we make a function at the savedObjectSchema level and use reducers, I don't think the config object is available at that time. But so far this is the only configurable property I can think of.
joshdover
approved these changes
Aug 2, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💔 Build Failed |
💚 Build Succeeded |
jbudz
approved these changes
Aug 6, 2019
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Aug 6, 2019
* Initial work * Fix type check * Accept core API changes * Fix broken tests * Destructure index pattern
mikecote
added a commit
that referenced
this pull request
Aug 6, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm making the task manager index configurable again. This was changed to static in this PR #39829 and will be configurable again once this PR merges.
Some of the core changes required:
indexPatternin savedObjectsSchemasstring | (config) => stringinstead of only being a string. This allows to pull values from the server config.createIndexMapconstructor args a single destructured argumentcreateIndexMaptake an instance ofSavedObjectsSchemainstead of the rawsavedObjectsSchemasto avoid code duplication.