You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches the assigned index patterns for all layers to the one selected in the data panel if the following conditions hold true:
All layers use the same index pattern
The operations in all layers work as is on the new index pattern
The isLayerTransferable function and the part of the operations figuring out whether they are transferable or not will be useful to also implement a manual switch on a per layer basis (I will do that in a separate PR).
About the "automatic switching" part:
I'm worried that the UI could be confusing in some situations:
The user wants to create one layer with index pattern A and one layer with index pattern B. They configure the first layer and then switch to index pattern B in the data panel -> layer 1 switches to index pattern B as well and the user has to switch it back to A manually.
The user creates a layer with index pattern A and switches to index pattern B on the left side. The layer changes the index pattern to B which is what the user expected. Then the user changes to index pattern C which is restricted (rollup indices), expecting the current layer to also switch to C, but that doesn't happen because the current operations are not compatible.
What do you think, @AlonaNadler@cchaos ? Can we make the UI more predictable? I have a feeling this way of doing things tries to be too clever and will fail in some situations.
The user wants to create one layer with index pattern A and one layer with index pattern B. They configure the first layer and then switch to index pattern B in the data panel -> layer 1 switches to index pattern B as well and the user has to switch it back to A manually.
How about we have a popup that says something along the lines of "Lens found the same fields in index B would you like to apply index b on the current visualization? yes change to index B / no do nothing`
The user creates a layer with index pattern A and switches to index pattern B on the left side. The layer changes the index pattern to B which is what the user expected. Then the user changes to index pattern C which is restricted (rollup indices), expecting the current layer to also switch to C, but that doesn't happen because the current operations are not compatible.
How about we have a popup that says you switched index pattern, how would you like to proceed? clear my chart/keep the chart as is and we open a new layer in that case
@AlonaNadler That's a nice way of handling that, but do we want to show a popup each time the user switches the index pattern (which would be implied by your suggestion above)?
How about only showing the popup if we could transfer the layer and just doing nothing if that's not the case? A new layer will be opened automatically once the user drags a field from the new index pattern into the workspace.
To make it less intrusive, @wylieconlon also had the idea to show the popup inline in the data panel (maybe above the field list).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flash1293
changed the title
Switches the assigned index patterns for all layers to the one selected in the data panel if the following conditions hold true:
The
isLayerTransferablefunction and the part of the operations figuring out whether they are transferable or not will be useful to also implement a manual switch on a per layer basis (I will do that in a separate PR).About the "automatic switching" part:
I'm worried that the UI could be confusing in some situations:
What do you think, @AlonaNadler @cchaos ? Can we make the UI more predictable? I have a feeling this way of doing things tries to be too clever and will fail in some situations.