Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Automation] ISTANBUL PRESET PATH is not working fine with constructor(private foo) #42683

Merged
merged 3 commits into from
Aug 9, 2019
Merged

[Automation] ISTANBUL PRESET PATH is not working fine with constructor(private foo) #42683

merged 3 commits into from
Aug 9, 2019

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Aug 6, 2019 •
edited
Loading

[Automation] ISTANBUL PRESET PATH is not working fine with constructor(private foo)

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@alexwizp
Copy link
Contributor Author

alexwizp commented Aug 6, 2019

@dmlemeshko could you please confirm that with these changes tests work fine

@alexwizp alexwizp self-assigned this Aug 6, 2019
@dmlemeshko
Copy link
Member

I can confirm that the fix helps dashboard functional tests to pass in #40512

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

dmlemeshko
dmlemeshko approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the help!

@alexwizp alexwizp marked this pull request as ready for review August 6, 2019 14:17
@alexwizp alexwizp added Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes Team:AppArch v7.4.0 v8.0.0 labels Aug 6, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

lukeelmers
lukeelmers requested changes Aug 6, 2019
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this one wasn't updated to remove this:

return (
  this.visTypes.byName[JSON.parse(savedObject.attributes.visState).type].icon ||
  'visualizeApp'
);

@alexwizp alexwizp force-pushed the origin/functional-code-coverage-fix branch from d5144ff to c7bc512 Compare August 6, 2019 20:46
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

lukeelmers
lukeelmers approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes here LGTM, but I don't know anything about how this fixes issues with istanbul, so I'll defer to @spalger on that.

This also feels like the type of thing that would be good to enforce via linter rules, if the issue is simply how the constructor is written.

@dmlemeshko
Copy link
Member

This also feels like the type of thing that would be good to enforce via linter rules, if the issue is simply how the constructor is written.

I also was thinking about it. @spalger what do you think?

@alexwizp alexwizp merged commit b27be54 into elastic:master Aug 9, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Aug 9, 2019
@alexwizp
[Automation] ISTANBUL PRESET PATH is not working fine with constructo…
4e0bf3f 
…r(private foo) (elastic#42683)
@alexwizp alexwizp mentioned this pull request Aug 9, 2019
Merged
alexwizp added a commit that referenced this pull request Aug 9, 2019
@alexwizp
[Automation] ISTANBUL PRESET PATH is not working fine with constructo…
7cd37f3 
…r(private foo) (#42683) (#43008)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 9, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into feature/rollu…
1394f75 
…p-metrics-selectall

* 'master' of github.com:elastic/kibana: (306 commits)
  [ML] Adding job overrides to the module setup endpoint (elastic#42946)
  [APM] Fix missing RUM url (elastic#42940)
  close socket timeouts without message (elastic#42456)
  Upgrade elastic/charts to 8.1.6 (elastic#42518)
  [ML] Delete old AngularJS data visualizer and refactor folders (elastic#42962)
  Add custom formatting for Date Nanos Format (elastic#42445)
  [Vega] Shim new platform - vega_fn.js -> vega_fn.js , use ExpressionFunction (elastic#42582)
  add socket.getPeerCertificate to KibanaRequest (elastic#42929)
  [Automation] ISTANBUL PRESET PATH is not working fine with constructor(private foo) (elastic#42683)
  [ML] Data frames: Updated stats structure. (elastic#42923)
  [Code] fixed the issue that the repository can not be deleted in some cases. (elastic#42841)
  [kbn-es] Support for passing regex value to ES (elastic#42651)
  Connect to Elasticsearch via SSL when starting kibana with `--ssl` (elastic#42840)
  Add Elasticsearch SSL support for integration tests (elastic#41765)
  Fix duplicate fetch in Visualize (elastic#41204)
  [DOCS] TSVB and Timelion clean up (elastic#42953)
  [Maps] [File upload] Fix maps geojson upload hanging on index step (elastic#42623)
  [APM] Use rounded bucket sizes for transaction distribution (elastic#42830)
  [yarn.lock] consistent resolve domain (elastic#42969)
  [Uptime] [Test] Repurpose unit test assertions to avoid flakiness (elastic#40650)
  ...
@alexwizp alexwizp deleted the origin/functional-code-coverage-fix branch January 4, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@lukeelmers lukeelmers lukeelmers approved these changes

@spalger spalger Awaiting requested review from spalger

Assignees

@alexwizp alexwizp

Labels
Feature:Embedding Embedding content via iFrame release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexwizp @dmlemeshko @elasticmachine @lukeelmers