Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift restriction of not allowing '_'-prefixed fields. Close #2551 #4291

Closed
wants to merge 1 commit into from
Closed

Conversation

algesten
Copy link

As long as Elasticsearch does not enforce this rule, neither should
Kibana.

As long as Elasticsearch does not enforce this rule, neither should
Kibana.
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@rashidkpc
Copy link
Contributor

Sorry, this is a defined convention in Kibana that we're not planning to change. _ fields are ambiguous, we don't know if they're part of the _source or one of elasticsearch's meta-data fields, further we have no way to handle conflicting fields. Thanks

@rashidkpc rashidkpc closed this Jun 22, 2015
@algesten
Copy link
Author

Why do you consider it necessary for Kibana to handle that ambiguity? Elasticsearch doesn't even warn you if you call a field "_timestamp" for instance. The user is left responsible for shooting themselves in the foot.

Would you consider this request if I code
it to be behind a configuration option that is off by default. I.e "allowUnderscoreSourceFields" with big warning signs that the user may get strange results if their name clashes with an internal field.

@rashidkpc
Copy link
Contributor

Sure, as long as it was off by default and we keep the warning in the doc_viewer. I want everyone to understand this is not recommended and will likely lead to serious bugs down the road.

That option should go in the advanced settings editor.

@algesten
Copy link
Author

Great! I'll take a stab at it soon.

@AdeMiller
Copy link

Did this get resolved? It's just bitten us as we moved to Kibana 4.

@algesten
Copy link
Author

algesten commented Dec 8, 2015

I've been meaning to look at it for ages. it's not a big job, but other work things have come in the way.

@f0o
Copy link

f0o commented Nov 12, 2021

How are we standing on this after 6 years and a massive increase in usage of _ prefixed fields (systemd, GELF, ...)?

Still no plans on supporting it without having to fork kibana and cherrypick this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants