Change check for isQueryFilter #43356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y_string property could be undefined.
stacey-gammon
added
release_note:skip
lukeelmers
approved these changes
Aug 15, 2019
|
Pinging @elastic/kibana-app-arch |
💚 Build Succeeded |
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Aug 15, 2019
…y_string property could be undefined. (elastic#43356)
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Aug 15, 2019
…y_string property could be undefined. (elastic#43356)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change check for isQueryFilter back to original, but acknowledge query_string property could be undefined.
The original fix (#41245) to solve the one migration error mentioned here: #41240 actually caused another bug.
It turns out that the original logic for determining an old style query filter vs a new filter was accurate, so that it should not have been left in the old filters array. We just needed to make sure that if it was an empty query, and
query_stringis undefined, we don't blow up the conversion.Fixes #43189