-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR] SLM create and edit policies #43390
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
6eecf34
add buttons and links to create/edit policy
jen-huang d1de1a4
set up add policy form
jen-huang 985a689
start create policy form, including loading/error states and redirect…
jen-huang 45243fc
add snapshot name field
jen-huang 516c3ef
Change page title upon app navigation, improve breadcrumbs
jen-huang 7429cf9
Add on cancel to policy form, reorder fields
jen-huang 5bbb120
Add simple cron field
jen-huang 6e01b70
Merge remote-tracking branch 'upstream/master' into feature/slm-create
jen-huang bc24450
First pass at create/edit policy functionality
jen-huang 6a2813c
Merge remote-tracking branch 'upstream/master' into feature/slm-create
jen-huang dbff38b
Adjust permissions for SLM tab
jen-huang d3c708e
Adjust no snapshots prompt based on if policies exist or not
jen-huang 2af6315
Add selectable indices to policy form
jen-huang 90cfd2c
Merge remote-tracking branch 'upstream/master' into feature/slm-create
jen-huang 58e0f35
Move cron editor from rollup jobs to ES UI shared folder
jen-huang dabd4d9
Used shared cron editor for slm policy create/edit
jen-huang bc05c7f
Adjust copies; add duplicate schedule warning callout
jen-huang 4700566
Surface in progress information
jen-huang 0b56d7d
Fix doc link for 7.x
jen-huang 44c4c4e
Fix rollup tests
jen-huang e828599
Merge remote-tracking branch 'upstream/master' into feature/slm-create
jen-huang 0d0987d
Copy edits from review
jen-huang cf2e381
Add ES endpoint to request review
jen-huang 3552bdb
Remove unused imports
jen-huang 923489d
Fix i18n by cleaning up typo'd text
jen-huang b1ebffd
Remove unused import
jen-huang 0f1b766
Fix permissions and i18n
jen-huang d6e4dfa
Revert change to Logistics copy
jen-huang 14565cb
Merge remote-tracking branch 'upstream/master' into feature/slm-create
jen-huang 79d2952
Fix bugs and PR feedback
jen-huang 495c301
Add cancel button to form and add comment for list
jen-huang 7eea3f4
Adjust timeout comment
jen-huang 9787825
Merge remote-tracking branch 'upstream/master' into feature/slm-create
jen-huang 281cc47
Fix bug with list of indices in detail panel when clicking through table
jen-huang 8fbe492
Add comment about EUI bug
jen-huang aaa8c67
Merge remote-tracking branch 'upstream/master' into feature/slm-create
jen-huang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 71 additions & 0 deletions
71
src/plugins/es_ui_shared/public/components/cron_editor/cron_hourly.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
/* | ||
* Licensed to Elasticsearch B.V. under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch B.V. licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
import React, { Fragment } from 'react'; | ||
import PropTypes from 'prop-types'; | ||
import { FormattedMessage } from '@kbn/i18n/react'; | ||
|
||
import { | ||
EuiFormRow, | ||
EuiSelect, | ||
EuiText, | ||
} from '@elastic/eui'; | ||
|
||
export const CronHourly = ({ | ||
minute, | ||
minuteOptions, | ||
onChange, | ||
}) => ( | ||
<Fragment> | ||
<EuiFormRow | ||
label={( | ||
<FormattedMessage | ||
id="esUi.cronEditor.cronHourly.fieldTimeLabel" | ||
defaultMessage="Minute" | ||
/> | ||
)} | ||
fullWidth | ||
data-test-subj="cronFrequencyConfiguration" | ||
> | ||
<EuiSelect | ||
options={minuteOptions} | ||
value={minute} | ||
onChange={e => onChange({ minute: e.target.value })} | ||
fullWidth | ||
prepend={( | ||
<EuiText size="xs"> | ||
<strong> | ||
<FormattedMessage | ||
id="esUi.cronEditor.cronHourly.fieldMinute.textAtLabel" | ||
defaultMessage="At" | ||
/> | ||
</strong> | ||
</EuiText> | ||
)} | ||
data-test-subj="cronFrequencyHourlyMinuteSelect" | ||
/> | ||
</EuiFormRow> | ||
</Fragment> | ||
); | ||
|
||
CronHourly.propTypes = { | ||
minute: PropTypes.string.isRequired, | ||
minuteOptions: PropTypes.array.isRequired, | ||
onChange: PropTypes.func.isRequired, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Fragment not needed