-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui/saved_objects components -> New Platform #43416
Conversation
Pinging @elastic/kibana-app-arch |
Closes #42865 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall makes sense, but we should document the fact that we also changed the component contract here to take in stateful services as props.
Even though you did this in a way that's backwards compatible for folks importing from ui/public
, it still feels like something we should have in the shared dev docs issue so people know that it isn't simply a matter of changing their imports.
src/legacy/ui/public/saved_objects/components/saved_object_save_modal.tsx
Show resolved
Hide resolved
💚 Build Succeeded |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I think it's low enough risk and effort to update the old import paths and delete src/legacy/ui/public/saved_objects/components/saved_object_save_modal.tsx
but that can be done in a separate PR.
💚 Build Succeeded |
💚 Build Succeeded |
* refactor: 💡 remove chrome usage in ui/saved_objects * refactor: 💡 move <SavedObjectFinder> to kibana-react NP plugin * test: 💍 move <SavedObjectFinder> tests to New Platform * refactor: 💡 move <SavedObjectSaveModal> to kibana-react plugin * test: 💍 fix TypeScript errors in a test * feat: 🎸 port translations to NP plugin * test: 💍 update Jest snapshot
💔 Build Failed |
Summary
ui/saved_objects
tokibana_react
New Platform plugin.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers
Dev Docs
Saved objects React components
<SavedObjectFinder>
and<SavedObjectSaveModal>
React components have been moved tokibana_react
New Platform plugin. Usage of the new components: