Add invalidateAPIKey support to security plugin #43707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
review
Team:Security
|
Pinging @elastic/kibana-security |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
ACK: will review tomorrow (since you're OOO till Monday anyway 😛 ) |
azasypkin
reviewed
Aug 23, 2019
💚 Build Succeeded |
azasypkin
approved these changes
Aug 27, 2019
💚 Build Succeeded |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Aug 27, 2019
* Initial work * Fix failing jest test * Use APIKeys class * Only use id to invalidate * Log all errors in invalidate function * Cleanup * Apply PR feedback
mikecote
added a commit
that referenced
this pull request
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm adding a function to the security plugin that allows to invalidate API keys in Elasticsearch.
This is intended to be used by the alerting plugin to cleanup API keys whenever generating new ones. We plan to use the key to delete itself which is currently doable but also requires
manage_api_keyscluster privilege..This PR follows the implementation of createAPIKey #42146.