-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure files in kbn_vislib_vis_types folder #43866
Restructure files in kbn_vislib_vis_types folder #43866
Conversation
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why we are not keeping the folders in the hierarchy to separate general purpose components and whole editors but re-export them on the top level? Then you can import easily from the same path but you don't lose a clean folder structure below.
Hey @flash1293 , I didn't really get your point.. |
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sulemanof Looked at the folder structure again and it's already separated as I would have done it - I misread the diff, sorry for that. LGTM
retest |
fc9399c
to
056320b
Compare
💔 Build Failed |
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pinging @elastic/kibana-app |
…ns/file_restructure2
@kobelb Maybe you can help with any ideas why security tests under x-pack are failing for this PR? |
💚 Build Succeeded |
* Files restructure * Get rid of export from index
Summary
This changes intend more comfortable usage of common options params and consistency with other places.
After further EUIfication we'll get rid of
controls
andeditor
s foldersInstead of importing components from different files, now they are available just from one place:
This also removes unused
point-series-options
directive with its template.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers