Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Human-readable text labels for series in histogram #439

Closed
wants to merge 1 commit into from

Conversation

bobrik
Copy link

@bobrik bobrik commented Aug 29, 2013

image

Adds query label or query string if there's no label to tooltip. Helps a lot on many intersecting lines.

@spalger
Copy link
Contributor

spalger commented Aug 29, 2013

Isn't this the same thing listed in the legend (assuming you have the legend turned on). I feel like the colored dot does a pretty good job associating the value with a query.

@bobrik
Copy link
Author

bobrik commented Aug 29, 2013

I have legend turned on, but look at the picture. It's hard to associate 20 colours with 20 metrics. It's even harder to find specific line if you only know colour.

And hey, there are colour-blind people!

@spalger
Copy link
Contributor

spalger commented Aug 29, 2013

Yes, very true. In that case, I'd personally prefer that it look more like this than following an equal sign and stretching the size of the tooltip so much. What do you think?

Implementation on my fork

histogram

@rashidkpc
Copy link
Contributor

My vote is leaving the text white, colored text is hard to read and dark legend colors will be nearly impossible against black.

Also drop the '|| item.series.info.query'. Queries are often huge and thats going to get ugly. If you need legend/tootip text, define it as the query alias

@spalger
Copy link
Contributor

spalger commented Aug 29, 2013

Sounds good, updated my fork to fall back to the current style when there isn't an alias.

Implementation on my fork

@bobrik
Copy link
Author

bobrik commented Aug 30, 2013

@spenceralger two lines in tooltip is a great idea.

@rashidkpc for us queries are usually short and people are quite lazy to add aliases. It's just not obvious to find where to add alias, actually. If query is huge and ugly — adding an alias will help, but query-by-default shouldn't break anything, especially if there are two lines for tooltip.

@spalger spalger closed this in #452 Aug 30, 2013
rashidkpc added a commit that referenced this pull request Oct 6, 2014
[discover] reprocess the rows on every response if we are sorting
harper-carroll pushed a commit to harper-carroll/kibana that referenced this pull request Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants