-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Human-readable text labels for series in histogram #439
Conversation
Isn't this the same thing listed in the legend (assuming you have the legend turned on). I feel like the colored dot does a pretty good job associating the value with a query. |
I have legend turned on, but look at the picture. It's hard to associate 20 colours with 20 metrics. It's even harder to find specific line if you only know colour. And hey, there are colour-blind people! |
Yes, very true. In that case, I'd personally prefer that it look more like this than following an equal sign and stretching the size of the tooltip so much. What do you think? |
My vote is leaving the text white, colored text is hard to read and dark legend colors will be nearly impossible against black. Also drop the '|| item.series.info.query'. Queries are often huge and thats going to get ugly. If you need legend/tootip text, define it as the query alias |
Sounds good, updated my fork to fall back to the current style when there isn't an alias. |
@spenceralger two lines in tooltip is a great idea. @rashidkpc for us queries are usually short and people are quite lazy to add aliases. It's just not obvious to find where to add alias, actually. If query is huge and ugly — adding an alias will help, but query-by-default shouldn't break anything, especially if there are two lines for tooltip. |
[discover] reprocess the rows on every response if we are sorting
Modified anubis messageretry config
Adds query label or query string if there's no label to tooltip. Helps a lot on many intersecting lines.