Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move angel values into vis rendering code #43968

Merged
merged 4 commits into from
Aug 28, 2019
Merged

Move angel values into vis rendering code #43968

merged 4 commits into from
Aug 28, 2019

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Aug 26, 2019 •
edited
Loading

Summary

This is based on the discussion while EUIfication of the Gauge options.

Get rid of setting minAngel and maxAngel inside the options editor and move the logic straight to visualization renderer.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@sulemanof sulemanof added release_note:skip Skip the PR/issue when compiling release notes Feature:Vis Editor Visualization editor issues Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 26, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

ppisljar
ppisljar approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@sulemanof
Copy link
Contributor Author

@flash1293 are you ok with these changes? 😊

flash1293
flash1293 approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM - really good simplification 👍

@sulemanof
Merge remote-tracking branch 'upstream/master' into fix/gauge_move_an…
6334a7c 
…gel_values

# Conflicts:
#	src/legacy/core_plugins/kbn_vislib_vis_types/public/components/options/gauge/style_panel.tsx
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@sulemanof sulemanof merged commit ef6276d into elastic:master Aug 28, 2019
@sulemanof sulemanof deleted the fix/gauge_move_angel_values branch August 28, 2019 11:02
@sulemanof sulemanof mentioned this pull request Aug 28, 2019
Merged
sulemanof added a commit to sulemanof/kibana that referenced this pull request Aug 28, 2019
@sulemanof
Move angel values into vis rendering code (elastic#43968)
3978c6b 
* Move angel values into vis rendering code

* Remove unused type
sulemanof added a commit that referenced this pull request Aug 28, 2019
@sulemanof
Move angel values into vis rendering code (#43968) (#44235)
b237c24 
* Move angel values into vis rendering code

* Remove unused type
@sulemanof sulemanof mentioned this pull request Sep 20, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@maryia-lapata maryia-lapata maryia-lapata approved these changes

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
backported Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sulemanof @elasticmachine @flash1293 @maryia-lapata @ppisljar