-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commonly used ranges to apm date-picker #44082
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
cc @sqren |
Hey @noctifer20, Thank you for your contribution - much appreciated! Can you please take a screenshot of how the change looks? |
x-pack/legacy/plugins/apm/public/components/shared/DatePicker/index.tsx
Outdated
Show resolved
Hide resolved
retest |
This looks great! I'll merge it shortly. Thanks again! |
💚 Build Succeeded |
@noctifer20 Merged 🚀 This needs to be backported to "7.x" which is the release branch for 7.4, 7.5 and all other future releases on the 7 major. I can do it for you but if you are interested in doing it I can help out. Basically you just need to cherry-pick 243a095 from master and create a PR towards 7.x branch. This is boring work, so we use a backport tool. If you already have cloned kibana you don't need to install the backport tool again, but can simply run Follow these steps to fill out the config.json: https://github.com/sqren/backport/blob/master/docs/configuration.md#global-config-backportconfigjson LMK if you need anything! |
Thanks! |
Summary
Closes #43505