Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commonly used ranges to apm date-picker #44082

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Conversation

noctifer20
Copy link
Contributor

Summary

Closes #43505

@noctifer20 noctifer20 requested a review from a team as a code owner August 27, 2019 12:15
@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@noctifer20
Copy link
Contributor Author

cc @sqren

@sorenlouv
Copy link
Member

Hey @noctifer20,

Thank you for your contribution - much appreciated! Can you please take a screenshot of how the change looks?

@sorenlouv
Copy link
Member

retest

@noctifer20
Copy link
Contributor Author

Can you please take a screenshot of how the change looks?

Thanks for fast review, it looks like this

Screen Shot 2019-08-27 at 4 41 22 PM

@sorenlouv
Copy link
Member

This looks great! I'll merge it shortly. Thanks again!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@sorenlouv sorenlouv merged commit 243a095 into elastic:master Aug 27, 2019
@sorenlouv
Copy link
Member

@noctifer20 Merged 🚀

This needs to be backported to "7.x" which is the release branch for 7.4, 7.5 and all other future releases on the 7 major.

I can do it for you but if you are interested in doing it I can help out. Basically you just need to cherry-pick 243a095 from master and create a PR towards 7.x branch.

This is boring work, so we use a backport tool. If you already have cloned kibana you don't need to install the backport tool again, but can simply run yarn backport (inside the kibana folder). It will probably complain about missing github credentials in {homefolder}/.backport/config.json.

Follow these steps to fill out the config.json: https://github.com/sqren/backport/blob/master/docs/configuration.md#global-config-backportconfigjson

LMK if you need anything!

@noctifer20
Copy link
Contributor Author

Thanks!
I will perform backport as I want to continue contributing to kibana/apm.
Once again, thanks for the instructions, I've configured backport tool and will submit PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Use more sensible "Commonly used" ranges in date picker
3 participants