-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable alerting and actions plugin by default #44083
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
Feature:Alerting
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
Team:Stack Services
v7.4.0
labels
Aug 27, 2019
Pinging @elastic/kibana-stack-services |
pmuellr
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bmcconaghy
approved these changes
Aug 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
💔 Build Failed |
💚 Build Succeeded |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Aug 27, 2019
* Disable alerting and actions plugin by default * Fix test failures
mikecote
added a commit
that referenced
this pull request
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that
Alerting
andActions
show up under feature controls in the UI (when creating a role then assigning space privileges). This is caused by the security PR registering features in order to test different scenarios (#41389). We'll disable the plugins by default until the UI is ready.Screenshot of what shows up in the assign spaces privileges UI without this change:
In order to have this working by default again in a development environment. Create a
kibana.dev.yml
file under/config
and add the following two lines: