Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] Update APM metric titles #44091

Merged
merged 2 commits into from
Aug 28, 2019

Conversation

cachedout
Copy link
Contributor

Summary

Update just the the titles of the graphs. Refs #44001 and #43998

After a discussion in #43998 we decided just to update the titles for 7.4 and to postpone additional work for a later time.

To test this PR, verify that the following graph titles exist on the Overview and Instance pages for APM server monitoring:

Response Count Intake API
Response Errors Intake API
Requests Intake API

Ensure you do not see metrics titled as any of the following:

Response Count
Response Errors
Requests

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring

@cachedout cachedout requested a review from simitt August 27, 2019 13:25
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cachedout cachedout merged commit 7fda81f into elastic:master Aug 28, 2019
cachedout added a commit to cachedout/kibana that referenced this pull request Aug 28, 2019
* Update APM metric titles

* Change to Request Count Intake API
cachedout added a commit that referenced this pull request Aug 28, 2019
* Update APM metric titles

* Change to Request Count Intake API
@rayafratkina
Copy link
Contributor

@cachedout @chrisronline @simitt can you please add a release_note label to this PR?

@cachedout
Copy link
Contributor Author

@rayafratkina Apologies. Label added. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants