Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes alert mustache templating with arrays #44094

Merged
merged 2 commits into from
Aug 27, 2019

Conversation

pmuellr
Copy link
Member

@pmuellr pmuellr commented Aug 27, 2019

fixes #44057

Prior to this fix, values inside an array were not subject to the
mustache transform.

fixes elastic#44057

Prior to this fix, values inside an array were not subject to the
mustache transform.
@pmuellr pmuellr requested a review from a team August 27, 2019 13:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services

@pmuellr pmuellr added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0 labels Aug 27, 2019
Copy link
Contributor

@gmmorris gmmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@pmuellr pmuellr merged commit b98954a into elastic:master Aug 27, 2019
pmuellr added a commit to pmuellr/kibana that referenced this pull request Aug 27, 2019
* Fixes alert mustache templating with arrays

fixes elastic#44057

Prior to this fix, values inside an array were not subject to the
mustache transform.
pmuellr added a commit that referenced this pull request Aug 27, 2019
* Fixes alert mustache templating with arrays

fixes #44057

Prior to this fix, values inside an array were not subject to the
mustache transform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alerting/transformActionParams does not handle arrays
5 participants