refactor: 💡 separate server-side function reg from executor #44531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamich
added
Feature:ExpressionLanguage
|
Pinging @elastic/kibana-app-arch |
💚 Build Succeeded |
ppisljar
requested changes
Sep 2, 2019
…ter-separate-server
💚 Build Succeeded |
streamich
added
the
Team:Presentation
|
Pinging @elastic/kibana-canvas |
…ter-separate-server
💔 Build Failed |
💚 Build Succeeded |
monfera
approved these changes
Sep 27, 2019
There was a problem hiding this comment.
Looks good to me on the Canvas side of things, @clintandrewhall maybe you wish to take a look too, having worked quite a bit with expressions
streamich
added a commit
that referenced
this pull request
Sep 27, 2019
…46775) * refactor: 💡 separate server-side function reg from executor * refactor: 💡 separate Canvas functionality of Interpreter * refactor: 💡 simplify, move server fn init into Canavas * fix: 🐛 adjust Expressions service usage after master merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #44199
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers