Makes the query panel's autocomplete "opt-in" #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tocomplete so that the user is required to use the arrow keys if they want autocomplete.
|
This breaks the ability to hit enter to submit a query, requires you to hit it twice no matter what you type. Also, if the user has ever used * as a search, it will be auto selected every time, no matter what they type. |
|
Yeah, you're right. Didn't notice that you had to hit enter twice... :/ |
spalger
pushed a commit
that referenced
this pull request
Oct 6, 2014
harper-carroll
pushed a commit
to harper-carroll/kibana
that referenced
this pull request
Jul 11, 2016
Removed old-dispatch from full proto.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the current text from the text box as the first result in the autocomplete so that the user is required to use the arrow keys if they want to select an autocomplete result. Addresses #358