Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved KbnError base class ⇒ kibana_utils #45532

Merged
merged 11 commits into from
Sep 16, 2019
Merged

Moved KbnError base class ⇒ kibana_utils #45532

merged 11 commits into from
Sep 16, 2019

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Sep 12, 2019 •
edited
Loading

Summary

Part of #44377

  • Moved errors base class to kibana_utils
  • Moved specific error types to appropriate modules

Dev Docs

  • Moved errors base class to kibana_utils, along with:
    • DuplicateField
    • SavedObjectNotFound
    • InvalidJSONProperty
  • Moved specific error types to appropriate modules
    • PersistedStateError ⇒ ui/persisted_state
    • VislibError and its children ⇒ ui/vislib
    • RequestFailure ⇒ ui/courier
  • Delete unused errors:
    • VersionConflict
    • MappingConflict
    • FetchFailure
    • RestrictedMapping
    • CacheWriteFailure
    • FieldNotFoundInCache
    • FetchFailure

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom added review release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v8.0.0 Team:AppArch v7.5.0 Feature:NP Migration labels Sep 12, 2019
@lizozom lizozom requested review from a team as code owners September 12, 2019 15:13
@lizozom lizozom self-assigned this Sep 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lizozom lizozom changed the title Moved errors base class to kibana_utils Moved errors base class → kibana_utils Sep 12, 2019
@lizozom lizozom mentioned this pull request Sep 12, 2019
Closed
26 tasks
jgowdyelastic
jgowdyelastic approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

@lizozom lizozom changed the title Moved errors base class → kibana_utils Moved errors base class ⇒ kibana_utils Sep 12, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom lizozom changed the title Moved errors base class ⇒ kibana_utils Moved KbnError base class ⇒ kibana_utils Sep 15, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

ppisljar
ppisljar approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom merged commit b91fbd7 into elastic:master Sep 16, 2019
lizozom pushed a commit to lizozom/kibana that referenced this pull request Sep 16, 2019
Moved KbnError base class ⇒ kibana_utils (elastic#45532)
56ba660 
* moved errors base class to kibana_utils

* Fixed tests for ui/errors imports

* fixed test path

* Restored Request Failure resp field

* Restored savedObjectType and savedObjectId

* simplified Error class extension

* updated constructors
@lizozom lizozom mentioned this pull request Sep 16, 2019
Merged
lizozom pushed a commit that referenced this pull request Sep 17, 2019
Moved KbnError base class ⇒ kibana_utils (#45532) (#45809)
273bba5 
* moved errors base class to kibana_utils

* Fixed tests for ui/errors imports

* fixed test path

* Restored Request Failure resp field

* Restored savedObjectType and savedObjectId

* simplified Error class extension

* updated constructors
@streamich streamich mentioned this pull request Sep 27, 2019
Closed
10 tasks
@lizozom lizozom deleted the newplatform/kibana-utils/errors branch November 14, 2019 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@ppisljar ppisljar ppisljar approved these changes

@rudolf rudolf rudolf approved these changes

Assignees

@lizozom lizozom

Labels
Feature:NP Migration release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. review v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lizozom @elasticmachine @rudolf @ppisljar @jgowdyelastic