Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Adds missing tooltips to Anomaly Explorer swimlane labels #46324

Merged
merged 3 commits into from
Sep 24, 2019

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Sep 23, 2019

Summary

Part of #18553. Adds missing tooltips for the Anomaly Explorer swimlane labels. This is particularly useful for long field values, where the full text is cropped in the lane label.

image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

@darnautov
Copy link
Contributor Author

@elasticmachine merge upstream

@peteharverson peteharverson changed the title [ML] swimlane tooltips [ML] Adds missing tooltips to Anomaly Explorer swimlane labels Sep 23, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, including IE11, and tooltips are now showing up on the lane labels. Should just change the positioning to use laneLabelWidth.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov darnautov merged commit 582eeb9 into elastic:master Sep 24, 2019
@darnautov darnautov deleted the ML-swimlane-tooltips branch September 24, 2019 09:18
darnautov added a commit to darnautov/kibana that referenced this pull request Sep 24, 2019
…ic#46324)

* [ML] swimlane tooltips

* [ML] x-asis tooltip offset with laneLabelWidth
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit late, but latest edit LGTM!

darnautov added a commit that referenced this pull request Sep 24, 2019
… (#46439)

* [ML] swimlane tooltips

* [ML] x-asis tooltip offset with laneLabelWidth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants