Remove MLs use of internal Spaces utilities #46366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
legrego
commented
Sep 23, 2019
| @@ -66,6 +69,41 @@ export class SpacesService { | |||
| return spaceId; | |||
| }; | |||
|
|
|||
| const getScopedClient = async (request: RequestFacade) => { | |||
There was a problem hiding this comment.
No functional changes; just moved from its original location below so it could be reused by getActiveSpace
legrego
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui |
|
Pinging @elastic/kibana-security |
💚 Build Succeeded |
kobelb
reviewed
Sep 24, 2019
x-pack/legacy/plugins/spaces/server/new_platform/spaces_service/spaces_service.test.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/spaces/server/new_platform/spaces_service/spaces_service.test.ts
Outdated
Show resolved
Hide resolved
Co-Authored-By: Brandon Kobel <brandon.kobel@gmail.com>
Yes, this was only meant to address ML's usage. Subsequent cleanup is already taking place in #46181, but I didn't want to include ML changes in that PR. |
kobelb
approved these changes
Sep 24, 2019
💚 Build Succeeded |
legrego
added a commit
to legrego/kibana
that referenced
this pull request
Sep 24, 2019
* remove MLs use of internal Spaces utilities * move logic to SpacesService for testability * make TS happy * Apply suggestions from code review Co-Authored-By: Brandon Kobel <brandon.kobel@gmail.com>
legrego
added a commit
that referenced
this pull request
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While migrating the Spaces server-side plugin to the new platform, I noticed that ML is importing the private
getActiveSpaceutility in order to retrieve the user's active space.This PR introduces a first-class way for plugins to retrieve this information in the legacy platform, so that I can continue with migration and cleanup of the spaces plugin.