Allow ['*'] for actions whitelistedHosts #46384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
review
Feature:Alerting
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-stack-services |
mikecote
changed the title
|
Tested this out on my machine and this works as advertised to where I can start up and run with this in my 👍 LGTM |
FrankHassanabad
approved these changes
Sep 23, 2019
💚 Build Succeeded |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Sep 24, 2019
mikecote
added a commit
that referenced
this pull request
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm changing the Joi validation for actions plugin config to allow
xpack.actions.whitelistedHosts: ['*']. The underlying code & tests support it but the validation wasn't aligned.