Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Remove table view from Analysis feature #46688

Merged
merged 4 commits into from
Sep 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,10 @@ import {
EuiTitle,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import React, { useState } from 'react';
import React from 'react';

import { GetLogEntryRateSuccessResponsePayload } from '../../../../../../common/http_api/log_analysis/results/log_entry_rate';
import { ChartView } from './chart';
import { isValidLogRateView, LogRateView, LogRateViewSwitcher } from './log_rate_view_switcher';
import { TableView } from './table';
import { TimeRange } from '../../../../../../common/http_api/shared/time_range';

export const LogRateResults = ({
Expand All @@ -41,8 +39,6 @@ export const LogRateResults = ({
{ defaultMessage: 'Loading log rate results' }
);

const [viewMode, setViewMode] = useState<LogRateView>('chart');

return (
<>
<EuiTitle size="m" aria-label={title}>
Expand Down Expand Up @@ -74,22 +70,7 @@ export const LogRateResults = ({
}
/>
) : (
<>
<EuiFlexGroup>
<EuiFlexItem grow={true}>
<LogRateViewSwitcher
selectedView={viewMode}
onChange={id => (isValidLogRateView(id) ? setViewMode(id) : undefined)}
/>
</EuiFlexItem>
</EuiFlexGroup>
<EuiSpacer size="l" />
{viewMode === 'chart' ? (
<ChartView data={results} setTimeRange={setTimeRange} timeRange={timeRange} />
) : (
<TableView data={results} />
)}
</>
<ChartView data={results} setTimeRange={setTimeRange} timeRange={timeRange} />
)}
</>
);
Expand Down

This file was deleted.

This file was deleted.

9 changes: 1 addition & 8 deletions x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -5321,13 +5321,6 @@
"xpack.infra.header.logsTitle": "ログ",
"xpack.infra.homePage.settingsTabTitle": "設定",
"xpack.infra.kibanaMetrics.cloudIdMissingErrorMessage": "{metricId} のモデルには cloudId が必要ですが、{nodeId} に cloudId が指定されていません。",
"xpack.infra.logs.analysis.logRateSection.table.actualLogEntryRateLabel": "実際のレート",
"xpack.infra.logs.analysis.logRateSection.table.anomalyScoreLabel": "異常スコア",
"xpack.infra.logs.analysis.logRateSection.table.startTimeLabel": "開始時刻",
"xpack.infra.logs.analysis.logRateSection.table.typicalLogEntryRateLabel": "平均レート",
"xpack.infra.logs.analysis.logRateSection.viewSwitcher.chartLabel": "レートチャート",
"xpack.infra.logs.analysis.logRateSection.viewSwitcher.legendLabel": "ログレートチャートと異常表ビューを切り替えます",
"xpack.infra.logs.analysis.logRateSection.viewSwitcher.tableLabel": "異常表",
"xpack.infra.logs.analysis.logRateSectionAnomalySeriesName": "異常",
"xpack.infra.logs.analysis.logRateSectionAreaSeriesName": "期待値",
"xpack.infra.logs.analysis.logRateSectionLineSeriesName": "15 分ごとのログエントリー (平均)",
Expand Down Expand Up @@ -11534,4 +11527,4 @@
"xpack.fileUpload.fileParser.noFileProvided": "エラー、ファイルが提供されていません",
"xpack.fileUpload.jsonIndexFilePicker.errorGettingIndexName": "インデックス名の取得中にエラーが発生: {errorMessage}"
}
}
}
9 changes: 1 addition & 8 deletions x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -5324,13 +5324,6 @@
"xpack.infra.header.logsTitle": "Logs",
"xpack.infra.homePage.settingsTabTitle": "设置",
"xpack.infra.kibanaMetrics.cloudIdMissingErrorMessage": "{metricId} 的模型需要云 ID,但没有为 {nodeId} 提供。",
"xpack.infra.logs.analysis.logRateSection.table.actualLogEntryRateLabel": "实际速率",
"xpack.infra.logs.analysis.logRateSection.table.anomalyScoreLabel": "异常分数",
"xpack.infra.logs.analysis.logRateSection.table.startTimeLabel": "开始时间",
"xpack.infra.logs.analysis.logRateSection.table.typicalLogEntryRateLabel": "通常速率",
"xpack.infra.logs.analysis.logRateSection.viewSwitcher.chartLabel": "速率图表",
"xpack.infra.logs.analysis.logRateSection.viewSwitcher.legendLabel": "在日志速率图表和异常表视图间切换",
"xpack.infra.logs.analysis.logRateSection.viewSwitcher.tableLabel": "异常表",
"xpack.infra.logs.analysis.logRateSectionAnomalySeriesName": "异常",
"xpack.infra.logs.analysis.logRateSectionAreaSeriesName": "预期",
"xpack.infra.logs.analysis.logRateSectionLineSeriesName": "每 15 分钟日志条目数(平均值)",
Expand Down Expand Up @@ -11536,4 +11529,4 @@
"xpack.fileUpload.fileParser.noFileProvided": "错误,未提供任何文件",
"xpack.fileUpload.jsonIndexFilePicker.errorGettingIndexName": "检索索引名称时出错:{errorMessage}"
}
}
}