Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] i18n for page manager, page preview, and shape preview #46865

Merged
merged 7 commits into from
Oct 3, 2019
Merged

[Canvas] i18n for page manager, page preview, and shape preview #46865

merged 7 commits into from
Oct 3, 2019

Conversation

poffdeluxe
Copy link
Contributor

Summary

  • i18n for
    • Page Manager
    • Page Preview
    • Shape Preview

@poffdeluxe poffdeluxe requested a review from a team as a code owner September 27, 2019 21:50
@poffdeluxe poffdeluxe added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:i18n release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.5.0 v8.0.0 labels Sep 27, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@poffdeluxe poffdeluxe changed the title i18n for page manager, page preview, and shape preview [Canvas] i18n for page manager, page preview, and shape preview Sep 27, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@poffdeluxe
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

crob611
crob611 approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things to clean up, but should be good to go after that.

x-pack/legacy/plugins/canvas/public/components/page_preview/page_controls.js Outdated
@@ -27,15 +31,19 @@ export const PageControls = ({ pageId, onDelete, onDuplicate }) => {
>
<EuiFlexItem grow={false}>
<EuiToolTip content="Clone">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content prop probably needs to be translated as well while you're here. It's where the content of of tooltip popover thingy comes from

image

x-pack/legacy/plugins/canvas/i18n/components.ts Outdated
ShapePreview: {
getShapeErrorMessage: () =>
i18n.translate('xpack.canvas.shapePreview.shapeErrorMessage', {
defaultMessage: 'An unexpected error occurred: the SVG was not parseable',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG should be a constant?

x-pack/legacy/plugins/canvas/public/components/shape_preview/shape_preview.tsx Outdated
@@ -24,7 +28,7 @@ export const ShapePreview = ({ shape }: Props) => {
.item(0);

if (!shapeSvg) {
throw new Error('An unexpected error occurred: the SVG was not parseable');
throw new Error(strings.getShapeErrorMessage());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do error messages like this need to be translated?

@elasticmachine
Copy link
Contributor

💔 Build Failed

@poffdeluxe
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@poffdeluxe poffdeluxe merged commit 9e8279b into elastic:master Oct 3, 2019
@poffdeluxe poffdeluxe deleted the i18n-canvas-page-related branch October 3, 2019 14:28
brianseeders pushed a commit to brianseeders/kibana that referenced this pull request Oct 3, 2019
@poffdeluxe @brianseeders
[Canvas] i18n for page manager, page preview, and shape preview (elas…
504714c 
…tic#46865)

* i18n for page manager, page preview, and shape preview

* Addressing feedback

* Forgot to remove ShapePreview
@poffdeluxe poffdeluxe mentioned this pull request Oct 3, 2019
Merged
poffdeluxe added a commit to poffdeluxe/kibana that referenced this pull request Oct 3, 2019
@poffdeluxe
[Canvas] i18n for page manager, page preview, and shape preview (elas…
4a867a1 
…tic#46865)

* i18n for page manager, page preview, and shape preview

* Addressing feedback

* Forgot to remove ShapePreview
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 3, 2019
@jloleysens
Merge branch 'console-fix-menu-actions-alignment' of github.com:jlole…
db42ef0 
…ysens/kibana into console-fix-menu-actions-alignment

* 'console-fix-menu-actions-alignment' of github.com:jloleysens/kibana: (59 commits)
  [Canvas] i18n for page manager, page preview, and shape preview (elastic#46865)
  [SIEM] hide siem data on empty string or _all (elastic#47166)
  [Uptime] Shim UI exports for new platform (elastic#44722)
  [Monitoring] Metricbeat Migration Wizard Tests (elastic#47139)
  [Logs UI] Support partitioned log rate results in API (elastic#46751)
  [APM] Remove beta badge from transaction breakdown (elastic#47163)
  test: 💍 convert Interpreter font function tests to Jest (elastic#47193)
  visualizations 👉 NP-ready (elastic#47142)
  [Uptime] Update pings chart colors (elastic#46780)
  Add scroll into view to avoid tooltip overlap (elastic#47106)
  Variety of quick a11y fixes (elastic#46569)
  [Graph] Empty workspace overlay (elastic#45547)
  [ML] Converts index and saved search selection to React (elastic#47117)
  [Uptime] Change default status filter in ping list to all on monitor page  (elastic#47108)
  refactor: 💡 convert Interpreter .js -> .ts (elastic#44545)
  Add TypeScript rules to STYLEGUIDE [skip ci] (elastic#47125)
  chore(NA): fix logic behind cleaning x-pack node modules on build (elastic#47091)
  [SIEM] Update Settings Text (elastic#47147)
  Add KQL functionality in the find function of the saved objects (elastic#41136)
  [Maps] Add 'InjectedData' class and revise so File Upload Features are assigned to new InjectedData instances (elastic#46381)
  ...
poffdeluxe added a commit that referenced this pull request Oct 3, 2019
@poffdeluxe
[7.x] [Canvas] i18n for page manager, page preview, and shape preview (…
51393d9 
…#46865) (#47234)

* [Canvas] i18n for page manager, page preview, and shape preview (#46865)

* i18n for page manager, page preview, and shape preview

* Addressing feedback

* Forgot to remove ShapePreview

* Fixing bad merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

Assignees
No one assigned
Labels
impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:i18n release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@poffdeluxe @elasticmachine @crob611