Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Cleanup to ScreenshotResults interface #47081

Merged
merged 4 commits into from
Oct 9, 2019

Conversation

tsullivan
Copy link
Member

Summary

This is just the minor code cleanup changes pulled from #46851

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@tsullivan tsullivan added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes review v7.5.0 v8.0.0 labels Oct 1, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@tsullivan tsullivan changed the title [Reporting] Pre-Cleanup for adding Performance Metrics to Screenshot Observable [Reporting] Cleanup to ScreenshotResults interface Oct 7, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@tsullivan
Copy link
Member Author

Code changes were reviewed in #46851

@tsullivan tsullivan merged commit 8936e21 into elastic:master Oct 9, 2019
@tsullivan tsullivan deleted the reporting/pre-perf-instrument branch October 9, 2019 16:14
tsullivan added a commit to tsullivan/kibana that referenced this pull request Oct 9, 2019
@tsullivan
Copy link
Member Author

The commit has the incorrect title in upstream: it should be [Reporting] Cleanup to ScreenshotResults interface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes review v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants