Expose injectedMetadata service temporarily #47319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
review
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
💔 Build Failed |
💚 Build Succeeded |
joshdover
approved these changes
Oct 4, 2019
| * exposed temporarily until https://github.com/elastic/kibana/issues/41990 done | ||
| * use *only* to retrieve config values | ||
| * @deprecated | ||
| * */ |
There was a problem hiding this comment.
It might be worth noting that NP plugins have no way of exposing injected vars from the server-side. It must be done from a legacy plugin.
mshustov
force-pushed
the
expose-inject-metadata-service
branch
from
b550435 to
6be62d5
Compare
💔 Build Failed
|
💚 Build Succeeded |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Oct 5, 2019
* expose injectMetadata until config service provided * add functional test * update types * fix tests. injectMetadata is a part of plugin contract * add comment about injectedVars API
mshustov
added a commit
that referenced
this pull request
Oct 5, 2019
Closed
mshustov
changed the title
💚 Build Succeeded |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide injectMetadata service to unblock plugin migration. Should be superseded by ConfigService introduced in #41990
I didn't add a wrapper around injectMetadata that mimic the future ConfigService interface because I believe they will have different implementations.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers