-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of addFiltersAndChangeTimeFilter #47450
Merged
lizozom
merged 7 commits into
elastic:master
from
lizozom:newplatform/filters/remove-index-patterns-1
Oct 7, 2019
Merged
Get rid of addFiltersAndChangeTimeFilter #47450
lizozom
merged 7 commits into
elastic:master
from
lizozom:newplatform/filters/remove-index-patterns-1
Oct 7, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizozom
added
release_note:plugin_api_changes
Contains a Plugin API changes section for the breaking plugin API changes section.
v8.0.0
v7.5.0
Feature:NP Migration
labels
Oct 7, 2019
Pinging @elastic/kibana-app-arch (Team:AppArch) |
ppisljar
approved these changes
Oct 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM, waiting for green CI
src/legacy/core_plugins/data/public/filter/filter_manager/lib/extract_time_filter.ts
Outdated
Show resolved
Hide resolved
💔 Build Failed |
retest |
💔 Build Failed |
26 tasks
💔 Build Failed |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:NP Migration
release_note:plugin_api_changes
Contains a Plugin API changes section for the breaking plugin API changes section.
v7.5.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #44377
To make the
query
services (filter, timefilter, query string) easier to use and also in order to move them to NP, we need to get rid of theindexPatterns
dependencies in those services.This PR gets rid of the
addFiltersAndChangeTimeFilter
method infilterManager
.Dev Docs
Deprecated
addFiltersAndChangeTimeFilter
.If needed, replace with
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers