Remove indexPatterns dependency from filter service #47471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 6, 2019 18:38
lizozom
added
v8.0.0
Team:AppArch
release_note:skip
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
26 tasks
💔 Build Failed |
💔 Build Failed |
added 3 commits
October 8, 2019 10:23
…atterns by generating the filter disaplyName in the relevant components.
lizozom
force-pushed
the
newplatform/filters/remove-index-patterns-2
branch
from
a2fef81
to
a3bb287
Compare
…rs/remove-index-patterns-2
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
💔 Build Failed |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
…rs/remove-index-patterns-2
💚 Build Succeeded |
…rs/remove-index-patterns-2
💚 Build Succeeded |
…rs/remove-index-patterns-2
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Oct 15, 2019
* Get rid of addFiltersAndChangeTimeFilter * ts fix * remove timefilter dependency from filter manager * code review change * Fixed bug in tests * changeTimeFilter * Refactored mappers and filter service to have no dependency on indexPatterns by generating the filter disaplyName in the relevant components. * Fix map and flatten test * Fixed filter state manager test * Remove async from addFIlters and setFilters * Fixed saved objects test - removed (display)value from url * Make removeAll sync * defer setFilters and removeAll in dashboard controller - temp hack * fixed translation in filter view * update strings * Fixed range rendering * map range converter
lizozom
pushed a commit
that referenced
this pull request
Oct 15, 2019
* Get rid of addFiltersAndChangeTimeFilter * ts fix * remove timefilter dependency from filter manager * code review change * Fixed bug in tests * changeTimeFilter * Refactored mappers and filter service to have no dependency on indexPatterns by generating the filter disaplyName in the relevant components. * Fix map and flatten test * Fixed filter state manager test * Remove async from addFIlters and setFilters * Fixed saved objects test - removed (display)value from url * Make removeAll sync * defer setFilters and removeAll in dashboard controller - temp hack * fixed translation in filter view * update strings * Fixed range rendering * map range converter
|
There are some stackoverflow issues which were causing failures in master/7.x. Looking to revert this PR here in the meantime. |
|
@tylersmalley @chrisdavies |
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Oct 16, 2019
* Get rid of addFiltersAndChangeTimeFilter * ts fix * remove timefilter dependency from filter manager * code review change * Fixed bug in tests * changeTimeFilter * Refactored mappers and filter service to have no dependency on indexPatterns by generating the filter disaplyName in the relevant components. * Fix map and flatten test * Fixed filter state manager test * Remove async from addFIlters and setFilters * Fixed saved objects test - removed (display)value from url * Make removeAll sync * defer setFilters and removeAll in dashboard controller - temp hack * fixed translation in filter view * update strings * Fixed range rendering * map range converter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #44377
Refactored mappers and filter service to have no dependency on
indexPatternsby generating and using the filter disaplyName only in the relevant components (FilterItem,FilterView,ApplyFiltersPopover).indexPatternsintoFilterManagercode.filter.meta.valuecan now either be a string or a function that receives a formatter. I wanted to rename it todisplayValue, but wasn't sure if this would't require further changes.setFilters,addFiltersandremoveAllsynchronousChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers