Prepare TypeScript in data/visualizations plugin for 3.7

src/legacy/core_plugins/data/public/index.ts

@@ -27,8 +27,7 @@ export function plugin() {
 // /// Export types & static code
 
 /** @public types */
-export type DataSetup = DataSetup;
-export type DataStart = DataStart;
+export { DataSetup, DataStart };
 
 export { FilterBar, ApplyFiltersPopover } from './filter';
 export {

src/legacy/core_plugins/data/public/index_patterns/index_patterns_service.ts

@@ -99,16 +99,4 @@ export {
 export type IndexPatternsSetup = ReturnType<IndexPatternsService['setup']>;
 
 /** @public */
-export type IndexPattern = IndexPattern;
-
-/** @public */
-export type IndexPatterns = IndexPatterns;
-
-/** @public */
-export type StaticIndexPattern = StaticIndexPattern;
-
-/** @public */
-export type Field = Field;
-
-/** @public */
-export type FieldType = FieldType;
+export { IndexPattern, IndexPatterns, StaticIndexPattern, Field, FieldType };

src/legacy/core_plugins/visualizations/public/np_ready/public/index.ts

@@ -33,8 +33,7 @@ import { PluginInitializerContext } from 'src/core/public';
 import { VisualizationsPlugin, VisualizationsSetup, VisualizationsStart } from './plugin';
 
 /** @public */
-export type VisualizationsSetup = VisualizationsSetup;
-export type VisualizationsStart = VisualizationsStart;
+export { VisualizationsSetup, VisualizationsStart };
 
 /** @public types */
 export { VisTypeAlias, VisType } from './types';

src/legacy/core_plugins/visualizations/public/np_ready/public/types/types_service.ts

@@ -83,7 +83,7 @@ export type TypesSetup = ReturnType<TypesService['setup']>;
 export type TypesStart = ReturnType<TypesService['start']>;
 
 /** @public types */
-export type VisTypeAlias = VisTypeAlias;
+export { VisTypeAlias };
 
 /** @public static code */
 // TODO once items are moved from ui/vis into this service

src/legacy/ui/public/visualize/loader/pipeline_helpers/utilities.ts

@@ -55,8 +55,6 @@ const getFieldFormat = (id: string | undefined, params: object = {}) => {
   }
 };
 
-export type FieldFormat = any;
-
 export const createFormat = (agg: AggConfig): SerializedFieldFormat => {
   const format: SerializedFieldFormat = agg.params.field ? agg.params.field.format.toJSON() : {};
   const formats: Record<string, () => SerializedFieldFormat> = {
@@ -159,3 +157,5 @@ export const getTableAggs = (vis: Vis): AggConfig[] => {
   const columns = tabifyGetColumns(vis.aggs.getResponseAggs(), !vis.isHierarchical());
   return columns.map(c => c.aggConfig);
 };
+
+export { FieldFormat };

src/plugins/data/common/field_formats/field_format.ts

@@ -169,7 +169,7 @@ export abstract class FieldFormat {
     };
   }
 
-  static from(convertFn: FieldFormatConvertFunction) {
+  static from(convertFn: FieldFormatConvertFunction): ReturnType<typeof createCustomFieldFormat> {
     return createCustomFieldFormat(convertFn);
   }