Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] type fix #47708

Merged
merged 3 commits into from
Oct 10, 2019
Merged

[SIEM] type fix #47708

merged 3 commits into from
Oct 10, 2019

Conversation

stephmilovic
Copy link
Contributor

Summary

Remove unused type that was throwing errors because it had the same name as an actual type, NetworkDnsData

@stephmilovic stephmilovic added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Oct 9, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@stephmilovic stephmilovic requested a review from XavierM October 9, 2019 14:50
@timroes
Copy link
Contributor

timroes commented Oct 9, 2019

There is also NetworkTopNFlowData which is duplicated in there. Can this be removed too? Otherwise we should rename the import, so it doesn't clash.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

@timroes timroes mentioned this pull request Oct 9, 2019
Merged
15 tasks
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

XavierM
XavierM approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephmilovic stephmilovic merged commit 8dc80a2 into elastic:master Oct 10, 2019
@stephmilovic stephmilovic deleted the dns-type-fix branch October 10, 2019 14:03
@stephmilovic stephmilovic mentioned this pull request Oct 10, 2019
Merged
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Oct 10, 2019
@stephmilovic
[SIEM] type fix (elastic#47708)
279c031 
* type fix

* remove other unused type

* rm unused var
stephmilovic added a commit that referenced this pull request Oct 10, 2019
@stephmilovic
[SIEM] type fix (#47708) (#47828)
3d9fb52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephmilovic @elasticmachine @timroes @XavierM