Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move FilterManager ⇒ NP #48391

Merged
merged 14 commits into from
Oct 29, 2019
Merged

Move FilterManager ⇒ NP #48391

merged 14 commits into from
Oct 29, 2019

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Oct 16, 2019 •
edited
Loading

Summary

Moved Filter Manager to New Platform.

Dev Docs

Moved Filter Manager to New Platform.

Usage in old platform:

import { npSetup, npStart } from 'ui/new_platform';
npStart.data.query.filterManager.getFilters()
...

Usage in new platform:

class MyPlugin {
   public setup(core: CoreSetup, { data }: MyPluginSetupDependencies) {
      data.query.filterManager.getFilters();
   }
   public start(core: CoreStart, { data }: MyPluginStartDependencies) {
      data.query.filterManager.getFilters();
   }
}

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom mentioned this pull request Oct 16, 2019
Closed
26 tasks
@lizozom lizozom self-assigned this Oct 16, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom lizozom force-pushed the newplatform/data-plugin/move-filter-manager-to-NP branch from 2789ec0 to 4d018b3 Compare October 16, 2019 14:50
@lizozom lizozom force-pushed the newplatform/data-plugin/move-filter-manager-to-NP branch from c1b41f2 to 8919cba Compare October 16, 2019 14:58
@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom lizozom added Feature:NP Migration release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:AppArch v7.6.0 v8.0.0 labels Oct 16, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom lizozom marked this pull request as ready for review October 23, 2019 14:56
@lizozom lizozom requested a review from a team October 23, 2019 14:56
@lizozom lizozom requested a review from a team as a code owner October 23, 2019 14:56
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom lizozom added the review label Oct 27, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

flash1293
flash1293 approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lens changes LGTM, didn't pull down and test.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

wylieconlon
wylieconlon approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall change LGTM

src/plugins/data/public/query/filter_manager/filter_manager.test.ts Outdated Show resolved Hide resolved
ppisljar
ppisljar approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom merged commit 19c4f87 into elastic:master Oct 29, 2019
lizozom pushed a commit to lizozom/kibana that referenced this pull request Oct 29, 2019
Move filter manager ⇒ NP (elastic#48391)
dc3a686 
* Moved filterManager to NP plugin

* Fixed applying filters to dashbaord.

* Minor fixes

* fixed types

* fix jest tests mock of filter

* Updated karma mccks

* Fixed lens test

* fixed import

* Removed comment
@lizozom lizozom mentioned this pull request Oct 29, 2019
Merged
lizozom pushed a commit that referenced this pull request Oct 29, 2019
Move filter manager ⇒ NP (#48391) (#49597)
ff31e78 
* Moved filterManager to NP plugin

* Fixed applying filters to dashbaord.

* Minor fixes

* fixed types

* fix jest tests mock of filter

* Updated karma mccks

* Fixed lens test

* fixed import

* Removed comment
@lizozom lizozom deleted the newplatform/data-plugin/move-filter-manager-to-NP branch November 14, 2019 13:05
@nreese nreese mentioned this pull request Nov 22, 2019
Merged
@lizozom lizozom changed the title Move filter manager ⇒ NP Move FilterManager ⇒ NP Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@flash1293 flash1293 flash1293 approved these changes

@wylieconlon wylieconlon wylieconlon approved these changes

@streamich streamich Awaiting requested review from streamich

Assignees

@lizozom lizozom

Labels
Feature:NP Migration release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. review v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lizozom @elasticmachine @wylieconlon @flash1293 @ppisljar